unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] lei q|up: fix write counter for v2
@ 2021-09-07 22:41 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2021-09-07 22:41 UTC (permalink / raw)
  To: meta

It's a bit confusing to see "0 written to ..." when we actually
wrote something.
---
 lib/PublicInbox/LeiToMail.pm | 1 +
 t/lei-q-save.t               | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/lib/PublicInbox/LeiToMail.pm b/lib/PublicInbox/LeiToMail.pm
index 01f08384..dbf58df9 100644
--- a/lib/PublicInbox/LeiToMail.pm
+++ b/lib/PublicInbox/LeiToMail.pm
@@ -361,6 +361,7 @@ sub _v2_write_cb ($$) {
 		$eml //= PublicInbox::Eml->new($bref);
 		return if $dedupe && $dedupe->is_dup($eml, $smsg);
 		$lei->{v2w}->ipc_do('add', $eml); # V2Writable->add
+		++$lei->{-nr_write};
 	}
 }
 
diff --git a/t/lei-q-save.t b/t/lei-q-save.t
index 7aa9b84e..743a7b70 100644
--- a/t/lei-q-save.t
+++ b/t/lei-q-save.t
@@ -179,6 +179,8 @@ test_lei(sub {
 	my (@before, @after);
 	require PublicInbox::MboxReader;
 	lei_ok(qw(q z:0.. -o), "v2:$v2");
+	like($lei_err, qr/^# ([1-9][0-9]*) written to \Q$v2\E/sm,
+		'non-zero write output to stderr');
 	lei_ok(qw(q z:0.. -o), "mboxrd:$home/before", '--only', $v2, '-j1,1');
 	open my $fh, '<', "$home/before";
 	PublicInbox::MboxReader->mboxrd($fh, sub { push @before, $_[0] });

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-09-07 22:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07 22:41 [PATCH] lei q|up: fix write counter for v2 Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).