unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* Serving message-id lookups from /all/
@ 2021-09-07 14:09 Konstantin Ryabitsev
  2021-09-07 22:02 ` [PATCH] news_www: favor ->ALL URL when using ->ALL Eric Wong
  0 siblings, 1 reply; 3+ messages in thread
From: Konstantin Ryabitsev @ 2021-09-07 14:09 UTC (permalink / raw)
  To: meta

Hello:

When using message-id lookups, the results are returned from individual lists,
e.g.:
    https://lore.kernel.org/20210901141637.fmvgs4hnk6m4ym7x@meerkat.local

This will redirect to:
    https://lore.kernel.org/tools/20210901141637.fmvgs4hnk6m4ym7x@meerkat.local/

Any way to have the message-id lookups be served from /all/, to make sure that
we see threads reconstituted from across all lists?

-K

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] news_www: favor ->ALL URL when using ->ALL
  2021-09-07 14:09 Serving message-id lookups from /all/ Konstantin Ryabitsev
@ 2021-09-07 22:02 ` Eric Wong
  2021-09-08 13:13   ` Konstantin Ryabitsev
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Wong @ 2021-09-07 22:02 UTC (permalink / raw)
  To: meta; +Cc: Konstantin Ryabitsev

This allows us to link to threads spread across multiple inboxes.

Reported-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Link: https://public-inbox.org/meta/20210907140954.4rlh6pn5fz4ljkxp@meerkat.local/
---
 lib/PublicInbox/NewsWWW.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/NewsWWW.pm b/lib/PublicInbox/NewsWWW.pm
index abafc4f9..d13731ae 100644
--- a/lib/PublicInbox/NewsWWW.pm
+++ b/lib/PublicInbox/NewsWWW.pm
@@ -82,7 +82,8 @@ sub call {
 				for (@$xr3) {
 					s/:[0-9]+:$x->{blob}\z// or next;
 					my $ibx = $by_eidx_key->{$_} // next;
-					my $url = $ibx->base_url or next;
+					my $url = $ALL->base_url($env) //
+							$ibx->base_url // next;
 					$url .= mid_escape($mid) . '/';
 					return redirect(302, $url);
 				}

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] news_www: favor ->ALL URL when using ->ALL
  2021-09-07 22:02 ` [PATCH] news_www: favor ->ALL URL when using ->ALL Eric Wong
@ 2021-09-08 13:13   ` Konstantin Ryabitsev
  0 siblings, 0 replies; 3+ messages in thread
From: Konstantin Ryabitsev @ 2021-09-08 13:13 UTC (permalink / raw)
  To: Eric Wong; +Cc: meta

On Tue, Sep 07, 2021 at 10:02:03PM +0000, Eric Wong wrote:
> This allows us to link to threads spread across multiple inboxes.
> 
> Reported-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
> Link: https://public-inbox.org/meta/20210907140954.4rlh6pn5fz4ljkxp@meerkat.local/

Works great, thanks!

-K


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-08 13:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07 14:09 Serving message-id lookups from /all/ Konstantin Ryabitsev
2021-09-07 22:02 ` [PATCH] news_www: favor ->ALL URL when using ->ALL Eric Wong
2021-09-08 13:13   ` Konstantin Ryabitsev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).