From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] news_www: avoid uninitialized variables
Date: Tue, 7 Sep 2021 14:05:48 +0000 [thread overview]
Message-ID: <20210907140548.1682-1-e@80x24.org> (raw)
PATH_INFO may not have enough slashes for newsgroup name in the
URL at all, so ensure we don't try to further process requests
which have no chance of having a newsgroup name.
---
lib/PublicInbox/NewsWWW.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/PublicInbox/NewsWWW.pm b/lib/PublicInbox/NewsWWW.pm
index d7dd637f..abafc4f9 100644
--- a/lib/PublicInbox/NewsWWW.pm
+++ b/lib/PublicInbox/NewsWWW.pm
@@ -45,6 +45,8 @@ sub call {
# some links may have the article number in them:
# /inbox.foo.bar/123456
my (undef, @parts) = split(m!/!, $env->{PATH_INFO});
+ @parts or return
+ [ 404, [qw(Content-Type text/plain)], ["404 Not Found\n"] ];
my ($ng, $article) = @parts;
my $pi_cfg = $self->{pi_cfg};
if (my $ibx = $pi_cfg->lookup_newsgroup($ng)) {
reply other threads:[~2021-09-07 14:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907140548.1682-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).