From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 9F8E51F8C8 for ; Thu, 2 Sep 2021 22:36:47 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/2] tests: "make check-run" favors reliability over speed Date: Thu, 2 Sep 2021 22:36:47 +0000 Message-Id: <20210902223647.6515-3-e@80x24.org> In-Reply-To: <20210902223647.6515-1-e@80x24.org> References: <20210902223647.6515-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Sharing a single lei-daemon across multiple processes still exhibits reliability problems, and reliably checking lei-daemon's inotify internals seems impossible without. Even without lei-daemon sharing, "make check-run" is a few seconds faster than "make check" for me. --- t/run.perl | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/t/run.perl b/t/run.perl index f6eb0ad3..5082125b 100755 --- a/t/run.perl +++ b/t/run.perl @@ -53,10 +53,11 @@ key2sub($_) for @tests; # precache my ($for_destroy, $lei_env, $lei_daemon_pid, $owner_pid); -# I get ECONNRESET from lei on FreeBSD 11.3 even with -# kern.ipc.soacceptqueue=1073741823, so persistent lei-daemon in tests -# is Linux-only for now: -if ($^O eq 'linux' && !$ENV{TEST_LEI_DAEMON_PERSIST_DIR} && +# TEST_LEI_DAEMON_PERSIST is currently broken. I get ECONNRESET from +# lei even with high kern.ipc.soacceptqueue=1073741823 or SOMAXCONN, not +# sure why. Also, testing our internal inotify usage is unreliable +# because lei-daemon uses a single inotify FD for all clients. +if ($ENV{TEST_LEI_DAEMON_PERSIST} && !$ENV{TEST_LEI_DAEMON_PERSIST_DIR} && (PublicInbox::Spawn->can('recv_cmd4') || eval { require Socket::MsgHdr })) { $lei_env = {};