From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 806BC1F8C7 for ; Tue, 31 Aug 2021 11:21:26 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 01/10] lei_mail_sync: forget_folder: simplify code Date: Tue, 31 Aug 2021 11:21:17 +0000 Message-Id: <20210831112126.13406-2-e@80x24.org> In-Reply-To: <20210831112126.13406-1-e@80x24.org> References: <20210831112126.13406-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: No need to bump refcounts of {dbh} nor declare extra variables for a rarely-called function. --- lib/PublicInbox/LeiMailSync.pm | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/PublicInbox/LeiMailSync.pm b/lib/PublicInbox/LeiMailSync.pm index b63f8dea..57b56b3c 100644 --- a/lib/PublicInbox/LeiMailSync.pm +++ b/lib/PublicInbox/LeiMailSync.pm @@ -403,13 +403,11 @@ EOF sub forget_folder { my ($self, $folder) = @_; - my ($fid, $sth); - $fid = delete($self->{fmap}->{$folder}) // + my $fid = delete($self->{fmap}->{$folder}) // fid_for($self, $folder) // return; - my $dbh = $self->{dbh}; - $dbh->do('DELETE FROM blob2name WHERE fid = ?', undef, $fid); - $dbh->do('DELETE FROM blob2num WHERE fid = ?', undef, $fid); - $dbh->do('DELETE FROM folders WHERE fid = ?', undef, $fid); + for my $t (qw(blob2name blob2num folders)) { + $self->{dbh}->do("DELETE FROM $t WHERE fid = ?", undef, $fid); + } } # only used for changing canonicalization errors