From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 2281C1F8C8 for ; Mon, 30 Aug 2021 23:44:55 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/3] www_text/mirror: spell out "external index" and "public inbox" Date: Mon, 30 Aug 2021 23:44:53 +0000 Message-Id: <20210830234454.32422-3-e@80x24.org> In-Reply-To: <20210830234454.32422-1-e@80x24.org> References: <20210830234454.32422-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: "extindex" and "public-inbox" are project-specific terms which are probably unsuitable for folks who are seeing this for the first time. Use "public inbox" when referring to actual public inboxes, since "public-inbox" is merely the name for this particular implementation and others have adopted the same concept (IMHO the concept is more important than any particular implementation). --- lib/PublicInbox/WwwText.pm | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/PublicInbox/WwwText.pm b/lib/PublicInbox/WwwText.pm index 858fc2f7..fabe39f6 100644 --- a/lib/PublicInbox/WwwText.pm +++ b/lib/PublicInbox/WwwText.pm @@ -246,9 +246,13 @@ sub coderepos_raw ($$) { my $cfg = $ctx->{www}->{pi_cfg}; my @ret; for my $cr_name (@$cr) { - $ret[0] //= <{ibx}->can('cloneurl') ? + 'public inbox' : 'external index'; + <get_all("coderepo.$cr_name.cgiturl"); if ($urls) { for (@$urls) { @@ -276,7 +280,8 @@ sub _mirror_help ($$) { $top_url =~ s!/[^/]+\z!/!; $$txt .= "public-inbox mirroring instructions\n\n"; if ($ibx->can('cloneurl')) { # PublicInbox::Inbox - $$txt .= "This inbox may be cloned and mirrored by anyone:\n"; + $$txt .= + "This public inbox may be cloned and mirrored by anyone:\n"; my @urls; my $max = $ibx->max_git_epoch; # TODO: some of these URLs may be too long and we may need to @@ -322,8 +327,8 @@ EOF } } else { # PublicInbox::ExtSearch $$txt .= <{www}->{pi_cfg}->{lc('publicInbox.wwwListing')}; if (($v // '') =~ /\A(?:all|match=domain)\z/) {