From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id A2C3A1F8C6;
	Fri, 27 Aug 2021 12:08:45 +0000 (UTC)
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: [PATCH 0/2] wwwlisting shows /all/
Date: Fri, 27 Aug 2021 12:08:43 +0000
Message-Id: <20210827120845.29682-1-e@80x24.org>
In-Reply-To: <20210826170114.r4j4cpf6hzrhzktt@nitro.local>
References: 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
List-Id: <meta.public-inbox.org>

Konstantin Ryabitsev wrote:
> Hello:
> 
> I switched the configuration to return wwwlisting as toplevel view (instead of
> redirecting / to /all/), but there's some discontent, because the easy
> interface to "search everything" is gone and unless someone knows about /all/,
> they wouldn't find out about it from the wwwlisting view.
> 
> How about, if there is an extindex "all" defined, the wwwlisting adds an extra
> search box:
> 
> [_________________] [search all] help
> 
> * 2021-08-26 16:54 - https://x-lore.kernel.org/all/
>   All of lore.kernel.org
> 
> ------------------------------------------------------
> 
> [_________________] [locate inbox]
> 
> * 2021-08-26 16:54 - https://x-lore.kernel.org/lkml/
>   [description]
>   [infourl]

I think that's too much vertical whitespace at the top of the
page, and multiple <form>s or <input> boxes at the top can get
confusing.

Just making /all/ show up at the top like a normal inbox (and
letting the admin decide on description) seems sufficient.  If
users can get to /all/ then they can search /all/ as normal.

I tried moving the <input>s next to infourl, but mixing <form>
and <pre> introduces a lot of vertical whitespace.


I also tried adding radio button (or drop-down):

	[_________________] [*] inboxes [ ] /all/   [search]

But extra <form> elements always confuse me whenever I encounter
them in any browser, so I decided to just leave things alone.

Eric Wong (2):
  www_listing: show ->ALL at top of HTML listing
  www_listing: fix odd "locate inbox" cases

 lib/PublicInbox/WwwListing.pm | 50 +++++++++++++++++++++++------------
 t/extindex-psgi.t             | 12 +++++++++
 2 files changed, 45 insertions(+), 17 deletions(-)