RFE: remove "- mbox.gz / Atom" from thread listing

RFE: remove "- mbox.gz / Atom" from thread listing

[Konstantin Ryabitsev]

Hello:

I was playing with mobile view and I think adding "- mbox.gz / Atom" on the
thread listing page is both unnecessary and makes the output too busy. E.g.
compare:

    [PATCH v2] drm: avoid races with
    modesetting rights
     2021-08-16 15:20 UTC  (2+ messages)
    - mbox.gz / Atom
    ` [Intel-gfx] ✗ Fi.CI.IGT: failure for "

    [GIT PULL] mtd: Changes for 5.14-rc7
    2021-08-16 15:20 UTC  - mbox.gz / Atom

    [PATCH 0/2] gitlab: prepare for limited
    CI minutes by not running by default
     2021-08-16 15:16 UTC  (7+ messages)
    - mbox.gz / Atom
    ` [PATCH 2/2] gitlab: don't run CI jobs
    by default on push to user forks

vs:

    [PATCH v2] drm: avoid races with
    modesetting rights
     2021-08-16 15:20 UTC  (2+ messages)
    ` [Intel-gfx] ✗ Fi.CI.IGT: failure for "

    [GIT PULL] mtd: Changes for 5.14-rc7
     2021-08-16 15:20 UTC

    [PATCH 0/2] gitlab: prepare for limited
    CI minutes by not running by default
     2021-08-16 15:16 UTC  (7+ messages)
    ` [PATCH 2/2] gitlab: don't run CI jobs
    by default on push to user forks

This is especially the case due to blue link highlights of "mbox.gz / Atom"
that break up visual flow of the topic and make it look confusing.

- I don't think most people would choose to download mbox.gz or click on the
  "Atom" link from the thread listing page -- there is a thread view for this
  purpose.
- Removing this would save quite a few bytes from being transferred
  unnecessarily and speed up page rendering.

Best regards,
-K

[PATCH] view: remove mbox.gz and Atom from topic view

[Eric Wong]

Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> - I don't think most people would choose to download mbox.gz or click on the
>   "Atom" link from the thread listing page -- there is a thread view for this
>   purpose.

Agreed, I don't think I've ever used them from the topic page...

Fwiw, I use mbox.gz downloads from per-topic pages, but I'm not
sure I've ever used Atom feeds outside of testing.

> - Removing this would save quite a few bytes from being transferred
>   unnecessarily and speed up page rendering.

Probably, the Message-ID being repeated ought to be good for
compressibility, but not having it at all would be more
efficient.

------8<-----
Subject: [PATCH] view: remove mbox.gz and Atom from topic view

This declutters the topic view since these links seem rarely
used.  Atom and mbox.gz links probably make most sense when
users have read the HTML and decide the topic is worth following
or downloading.

Reported-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Link: https://public-inbox.org/meta/20210816154444.sj3ks2sikq3x2ywx@nitro.local/
---
 lib/PublicInbox/View.pm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index c80a675e..17d38302 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -1154,10 +1154,8 @@ sub dump_topics {
 			$anchor = '#t'; # thread skeleton
 		}
 
-		my $mbox = qq(<a\nhref="$href/t.mbox.gz">mbox.gz</a>);
-		my $atom = qq(<a\nhref="$href/t.atom">Atom</a>);
 		my $s = "<a\nhref=\"$href/T/$anchor\">$top_subj</a>\n" .
-			" $ds UTC $n - $mbox / $atom\n";
+			" $ds UTC $n\n";
 		for (my $i = 0; $i < scalar(@extra); $i += 2) {
 			my $level = $extra[$i];
 			my $subj = $extra[$i + 1]; # already normalized

[SQUASH] fix tests for missing t.mbox.gz links

[Eric Wong]

:x
---
 t/psgi_bad_mids.t | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/psgi_bad_mids.t b/t/psgi_bad_mids.t
index f92e4f97..8e531b54 100644
--- a/t/psgi_bad_mids.t
+++ b/t/psgi_bad_mids.t
@@ -53,7 +53,7 @@ test_psgi(sub { $www->call(@_) }, sub {
 		ok(index($raw, $mid) < 0, "escaped $mid");
 	}
 
-	my (@xmids) = ($raw =~ m!\bhref="([^"]+)/t\.mbox\.gz"!sg);
+	my (@xmids) = ($raw =~ m!\bhref="([^"]+?)/T/#u"!sg);
 	is(scalar(@xmids), scalar(@mids),
 		'got escaped links to all messages');
 

Re: [PATCH] view: remove mbox.gz and Atom from topic view

[Konstantin Ryabitsev]

On Mon, Aug 16, 2021 at 11:35:20PM +0000, Eric Wong wrote:
> > - I don't think most people would choose to download mbox.gz or click on the
> >   "Atom" link from the thread listing page -- there is a thread view for this
> >   purpose.
> 
> Agreed, I don't think I've ever used them from the topic page...
> 
> Fwiw, I use mbox.gz downloads from per-topic pages, but I'm not
> sure I've ever used Atom feeds outside of testing.
> 
> > - Removing this would save quite a few bytes from being transferred
> >   unnecessarily and speed up page rendering.
> 
> Probably, the Message-ID being repeated ought to be good for
> compressibility, but not having it at all would be more
> efficient.

Looking good on x-lore!
Thanks!

-K