[PATCH] view: remove mbox.gz and Atom from topic view

[Eric Wong <e@80x24.org>]

Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> - I don't think most people would choose to download mbox.gz or click on the
>   "Atom" link from the thread listing page -- there is a thread view for this
>   purpose.

Agreed, I don't think I've ever used them from the topic page...

Fwiw, I use mbox.gz downloads from per-topic pages, but I'm not
sure I've ever used Atom feeds outside of testing.

> - Removing this would save quite a few bytes from being transferred
>   unnecessarily and speed up page rendering.

Probably, the Message-ID being repeated ought to be good for
compressibility, but not having it at all would be more
efficient.

------8<-----
Subject: [PATCH] view: remove mbox.gz and Atom from topic view

This declutters the topic view since these links seem rarely
used.  Atom and mbox.gz links probably make most sense when
users have read the HTML and decide the topic is worth following
or downloading.

Reported-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Link: https://public-inbox.org/meta/20210816154444.sj3ks2sikq3x2ywx@nitro.local/
---
 lib/PublicInbox/View.pm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index c80a675e..17d38302 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -1154,10 +1154,8 @@ sub dump_topics {
 			$anchor = '#t'; # thread skeleton
 		}
 
-		my $mbox = qq(<a\nhref="$href/t.mbox.gz">mbox.gz</a>);
-		my $atom = qq(<a\nhref="$href/t.atom">Atom</a>);
 		my $s = "<a\nhref=\"$href/T/$anchor\">$top_subj</a>\n" .
-			" $ds UTC $n - $mbox / $atom\n";
+			" $ds UTC $n\n";
 		for (my $i = 0; $i < scalar(@extra); $i += 2) {
 			my $level = $extra[$i];
 			my $subj = $extra[$i + 1]; # already normalized