From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] li2wrap: avoid double-close on Linux::Inotify2 <2.3
Date: Fri, 6 Aug 2021 00:29:52 +0000 [thread overview]
Message-ID: <20210806002952.22924-1-e@80x24.org> (raw)
LI2Wrap was not working as expected due to the missing bless
to override ->DESTROY. This bug showed up in an message check in
t/lei-q-remote-import.t
Fixes: 7fc6e30aeab9925b ("lei: close inotify FD in forked child")
---
lib/PublicInbox/LI2Wrap.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/PublicInbox/LI2Wrap.pm b/lib/PublicInbox/LI2Wrap.pm
index 61cf4bee..204850a6 100644
--- a/lib/PublicInbox/LI2Wrap.pm
+++ b/lib/PublicInbox/LI2Wrap.pm
@@ -12,6 +12,7 @@ sub wrapclose {
my ($inot) = @_;
my $fd = $inot->fileno;
open my $fh, '<&=', $fd or die "open <&= $fd $!";
+ bless $inot, __PACKAGE__;
}
sub DESTROY {} # no-op
reply other threads:[~2021-08-06 0:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806002952.22924-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).