From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 0/4] favor shorter binary OID comparisons
Date: Sun, 25 Jul 2021 00:43:28 +0000 [thread overview]
Message-ID: <20210725004332.23896-1-e@80x24.org> (raw)
We were doing unneccessary 40-byte hex comparisons for SHA-1s
in our code when 20-byte comparisons would've been sufficient.
3/4 is a typo fix which didn't hit any warnings before,
either...
Eric Wong (4):
extsearchidx: favor binary comparison in common case
lei_search: favor binary OID comparisons
lei_inspect: fix typo
lei_mail_sync: locations_for API uses oidbin for comparisons
lib/PublicInbox/ExtSearchIdx.pm | 4 ++--
lib/PublicInbox/LeiExportKw.pm | 7 +++----
lib/PublicInbox/LeiInspect.pm | 7 ++++---
lib/PublicInbox/LeiMailSync.pm | 7 ++++---
lib/PublicInbox/LeiSearch.pm | 6 +++---
t/lei_mail_sync.t | 4 ++--
6 files changed, 18 insertions(+), 17 deletions(-)
next reply other threads:[~2021-07-25 0:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 0:43 Eric Wong [this message]
2021-07-25 0:43 ` [PATCH 1/4] extsearchidx: favor binary comparison in common case Eric Wong
2021-07-25 0:43 ` [PATCH 2/4] lei_search: favor binary OID comparisons Eric Wong
2021-07-25 0:43 ` [PATCH 3/4] lei_inspect: fix typo Eric Wong
2021-07-25 0:43 ` [PATCH 4/4] lei_mail_sync: locations_for API uses oidbin for comparisons Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210725004332.23896-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).