From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 234451F5AE for ; Wed, 9 Jun 2021 00:11:11 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] lei edit-search: fix and add a (weak) test Date: Wed, 9 Jun 2021 00:11:11 +0000 Message-Id: <20210609001111.8601-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: This broke recently and lacked an automated test, so rely on EDITOR=cat to ensure we have some coverage. Fixes: d2670108f71b1eff ("pkt_op: make pkt_do an OO method") --- lib/PublicInbox/LeiEditSearch.pm | 2 +- t/lei-q-save.t | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/LeiEditSearch.pm b/lib/PublicInbox/LeiEditSearch.pm index 13713d24..82dfbf63 100644 --- a/lib/PublicInbox/LeiEditSearch.pm +++ b/lib/PublicInbox/LeiEditSearch.pm @@ -19,7 +19,7 @@ sub lei_edit_search { my ($op_c, $op_p) = PublicInbox::PktOp->pair; # $op_p will EOF when $EDITOR is done $op_c->{ops} = { '' => [$lss->can('edit_done'), $lss, $lei] }; - $lei->send_exec_cmd([ @$lei{qw(0 1 2)}, $op_p ], \@cmd, {}); + $lei->send_exec_cmd([ @$lei{qw(0 1 2)}, $op_p->{op_p} ], \@cmd, {}); } *_complete_edit_search = \&PublicInbox::LeiUp::_complete_up; diff --git a/t/lei-q-save.t b/t/lei-q-save.t index 694b33b2..6c592088 100644 --- a/t/lei-q-save.t +++ b/t/lei-q-save.t @@ -195,5 +195,8 @@ test_lei(sub { glob("$v2s/git/0.git/objects/*/*"))); ok($shared < $orig, 'fewer bytes stored with --shared') or diag "shared=$shared orig=$orig"; + + lei_ok([qw(edit-search), $v2s], { VISUAL => 'cat', EDITOR => 'cat' }); + like($lei_out, qr/^\[lei/sm, 'edit-search can cat'); }); done_testing;