From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B7ADC1F5AE for ; Sat, 5 Jun 2021 21:06:06 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] lei: don't drop WQ workers on normal exit Date: Sat, 5 Jun 2021 21:06:06 +0000 Message-Id: <20210605210606.7553-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: This is dangerous and causes race conditions on commands which utilize multiple workqueues. --- lib/PublicInbox/LEI.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index 2dd21fc6..8adf70fa 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -480,6 +480,7 @@ sub sigint_reap { sub fail ($$;$) { my ($self, $buf, $exit_code) = @_; + $self->{failed}++; err($self, $buf) if defined $buf; # calls fail_handler: $self->{pkt_op_p}->pkt_do('!') if $self->{pkt_op_p}; @@ -1043,7 +1044,7 @@ sub accept_dispatch { # Listener {post_accept} callback sub dclose { my ($self) = @_; delete $self->{-progress}; - _drop_wq($self); + _drop_wq($self) if $self->{failed}; close(delete $self->{1}) if $self->{1}; # may reap_compress $self->close if $self->{-event_init_done}; # PublicInbox::DS::close }