From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH 5/6] lei: handle a single IMAP message in most places
Date: Fri, 28 May 2021 09:37:40 +0000 [thread overview]
Message-ID: <20210528093740.GB18768@dcvr> (raw)
In-Reply-To: <20210528000757.20500-6-e@80x24.org>
Eric Wong <e@80x24.org> wrote:
> v2: enforce UID in URL, fail without
Pushed v3 as commit 9b3cd5e254fafa08c774a24f85c2b2eac12a9de5
v3: fix error reporting (s/fail/child_error/)
Using ->fail was causing errors to cascade elsewhere, not 100%
sure why...
interdiff:
diff -u b/lib/PublicInbox/LeiLcat.pm b/lib/PublicInbox/LeiLcat.pm
--- b/lib/PublicInbox/LeiLcat.pm
+++ b/lib/PublicInbox/LeiLcat.pm
@@ -28,7 +28,7 @@
require PublicInbox::URIimap;
$u = PublicInbox::URIimap->new($u);
defined($u->uid) ? lcat_imap_uid_uri($lei, $u) :
- $lei->fail("# no UID= in $u");
+ $lei->child_error(1 << 8, "# no UID= in $u");
'""'; # blank query, using {lcat_blob}
} elsif ($x =~ m!\b([a-z]+?://\S+)!i) {
my $u = $1;
next prev parent reply other threads:[~2021-05-28 9:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 10:49 [PATCH] lei: handle a single IMAP message in most places Eric Wong
2021-05-28 0:07 ` [PATCH 0/6] lei: odds and ends and a resend Eric Wong
2021-05-28 0:07 ` [PATCH 1/6] viewdiff: make $UNSAFE a variable Eric Wong
2021-05-28 0:07 ` [PATCH 2/6] viewdiff: escape '{' and '}' for regexp Eric Wong
2021-05-28 0:07 ` [PATCH 3/6] lei_mail_sync: debug code for uncommitted txn Eric Wong
2021-05-28 9:35 ` Eric Wong
2021-05-28 0:07 ` [PATCH 4/6] lei: mark reorder-and-rewrite-local-history as a TODO item Eric Wong
2021-05-28 0:07 ` [PATCH 5/6] lei: handle a single IMAP message in most places Eric Wong
2021-05-28 9:37 ` Eric Wong [this message]
2021-05-28 0:07 ` [PATCH 6/6] lei: add TODO item for FUSE mount Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528093740.GB18768@dcvr \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).