unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/2] lei_mail_sync: reject IMAP URLs w/o UIDVALIDITY
Date: Sun, 23 May 2021 21:36:51 +0000	[thread overview]
Message-ID: <20210523213651.24941-3-e@80x24.org> (raw)
In-Reply-To: <20210523213651.24941-1-e@80x24.org>

It's inappropriate to store sync information without
UIDVALIDITY, so add an assertion to prevent it.
---
 lib/PublicInbox/LeiMailSync.pm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/PublicInbox/LeiMailSync.pm b/lib/PublicInbox/LeiMailSync.pm
index b2986686..63076fa1 100644
--- a/lib/PublicInbox/LeiMailSync.pm
+++ b/lib/PublicInbox/LeiMailSync.pm
@@ -7,6 +7,7 @@ use strict;
 use v5.10.1;
 use DBI;
 use PublicInbox::ContentHash qw(git_sha);
+use Carp ();
 
 sub dbh_new {
 	my ($self, $rw) = @_;
@@ -88,6 +89,10 @@ UPDATE folders SET loc = ? WHERE fid = ?
 EOM
 			return $fid;
 		}
+	} elsif ($rw && $folder =~ m!\Aimaps?://!i) {
+		require PublicInbox::URIimap;
+		PublicInbox::URIimap->new($folder)->uidvalidity //
+			Carp::croak("BUG: $folder has no UIDVALIDITY");
 	}
 	return unless $rw;
 

      parent reply	other threads:[~2021-05-23 21:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-23 21:36 [PATCH 0/2] lei IMAP usability stuff Eric Wong
2021-05-23 21:36 ` [PATCH 1/2] lei inspect: use LeiMailSync->match_imap_url Eric Wong
2021-05-23 21:36 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210523213651.24941-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).