[PATCH] contrib/css/216light: increase contrast of normal text

[PATCH] contrib/css/216light: increase contrast of normal text

[Yaseen Mowzer]

On my monitor #333 on #fff is a little bit hard to read. I think normal
text should just be #000.

The head style [1] uses the contrast between #333 and #000 for emphasis,
after this change the emphasis will be lost. It's really subtle
emphasis, so it's not a huge loss.

    [1]    *.head { color:#000 }
---
 contrib/css/216light.css | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/css/216light.css b/contrib/css/216light.css
index c66cfdfe..fa257339 100644
--- a/contrib/css/216light.css
+++ b/contrib/css/216light.css
@@ -4,7 +4,7 @@
  * Suitable for print, and blinding people with brightness.
  * Haphazardly thrown together because bright colors hurt my eyes
  */
-* { background:#fff; color:#333 }
+* { background:#fff; color:#000 }
 
 /*
  * Underlined links add visual noise which make them hard-to-read.
-- 
2.31.1

[PATCH v2] contrib/css/216light: increase contrast of normal text

[Yaseen Mowzer]

On my monitor #333 on #fff is a little bit hard to read. I think normal
text should just be #000.

The head style uses the contrast between #333 and #000 for emphasis. To
preserve the emphasis `font-weight: bold` was added to the head style.
---

I changed my mind about the head style. I think we should make it bold
instead of loosing the emphasis. This is more consitent with what git
diff does.

 contrib/css/216light.css | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/contrib/css/216light.css b/contrib/css/216light.css
index c66cfdfe..c68ca9ce 100644
--- a/contrib/css/216light.css
+++ b/contrib/css/216light.css
@@ -4,7 +4,7 @@
  * Suitable for print, and blinding people with brightness.
  * Haphazardly thrown together because bright colors hurt my eyes
  */
-* { background:#fff; color:#333 }
+* { background:#fff; color:#000 }
 
 /*
  * Underlined links add visual noise which make them hard-to-read.
@@ -22,7 +22,7 @@ a:visited { color:#808 }
  */
 *.add { color:#060 }
 *.del {color:#900 }
-*.head { color:#000 }
+*.head { color:#000; font-weight:bold }
 *.hunk { color:#960 }
 
 /*
-- 
2.31.1

Re: [PATCH v2] contrib/css/216light: increase contrast of normal text

[Eric Wong]

Yaseen Mowzer <yaseen@mowzer.co.za> wrote:
> On my monitor #333 on #fff is a little bit hard to read. I think normal
> text should just be #000.

I wasn't completely sure about it, myself; but I can't stand
light backgrounds in general floaters in my eyes are getting
worse (AFAIK there's no treatment, either).

> The head style uses the contrast between #333 and #000 for emphasis. To
> preserve the emphasis `font-weight: bold` was added to the head style.
> ---
> 
> I changed my mind about the head style. I think we should make it bold
> instead of loosing the emphasis. This is more consitent with what git
> diff does.

OK, more inline...

> diff --git a/contrib/css/216light.css b/contrib/css/216light.css
> index c66cfdfe..c68ca9ce 100644
> --- a/contrib/css/216light.css
> +++ b/contrib/css/216light.css
> @@ -4,7 +4,7 @@
>   * Suitable for print, and blinding people with brightness.
>   * Haphazardly thrown together because bright colors hurt my eyes
>   */
> -* { background:#fff; color:#333 }
> +* { background:#fff; color:#000 }

I find #000 on #fff too intense for large swaths of text.
Would #030 or #003 (dark green/blue) work for you?

>  /*
>   * Underlined links add visual noise which make them hard-to-read.
> @@ -22,7 +22,7 @@ a:visited { color:#808 }
>   */
>  *.add { color:#060 }
>  *.del {color:#900 }
> -*.head { color:#000 }
> +*.head { color:#000; font-weight:bold }

I've been avoiding bold for stuff that might be important
because some fonts or low-res displays make bold hard-to-read.

Maybe something subtle like #300 work?  Or keep it #000
if foreground becomes #030 or #003.

(I think .head is the least important element to highlight by
 a long shot).

>  *.hunk { color:#960 }
>  
>  /*

Re: [PATCH v2] contrib/css/216light: increase contrast of normal text

[Yaseen Mowzer]

Eric Wong <e@80x24.org> writes:
> I find #000 on #fff too intense for large swaths of text.

Maybe it's just a problem with my monitor having too low contrast... I
see a lot of websites don't actually use #000 for text but something
closer to #222 or #333. Although for some reason it felt much worse on
public-inbox than other sites.

I should probably install a plugin or get a better monitor instead of
trying to fix the rest of the world :P

> Would #030 or #003 (dark green/blue) work for you?

I think it would be strange for the main text to be a color other than
black.

Re: [PATCH v2] contrib/css/216light: increase contrast of normal text

[Eric Wong]

Yaseen Mowzer <yaseen@mowzer.co.za> wrote:
> Eric Wong <e@80x24.org> writes:
> > I find #000 on #fff too intense for large swaths of text.
> 
> Maybe it's just a problem with my monitor having too low contrast... I
> see a lot of websites don't actually use #000 for text but something
> closer to #222 or #333. Although for some reason it felt much worse on
> public-inbox than other sites.

Yes, #222 or #111 might be better for users with >=16-bit color;
but I also don't want to exclude users with <=256 color displays.

> I should probably install a plugin or get a better monitor instead of
> trying to fix the rest of the world :P

Given I care about users with 8-bit color, I think monitors with
worn-out elements deserve the same consideration.

Of course, there are plugins (Stylus for Firefox?) and browsers
like dillo support custom colors.

> > Would #030 or #003 (dark green/blue) work for you?
> 
> I think it would be strange for the main text to be a color other than
> black.

Not really, black is the most difficult color to reproduce
accurately.  Ballpoint pens are often blue, and some of the
inexpensive "black" ones are purple or gray.

I've seen inkjet printers use dark brown/green or purple if the
printer is out of black ink.  Sometimes getting paper with black
text wet reveals it as a dark purple.

Anyways, if you could give an opinion on a darker color that
still works within the 216-color limitation, I will likely merge it.

Thanks for bringing this up.

Re: [PATCH v2] contrib/css/216light: increase contrast of normal text

[Yaseen Mowzer]

Yaseen Mowzer <yaseen@mowzer.co.za> wrote:
> On my monitor #333 on #fff is a little bit hard to read.

Eric Wong <e@80x24.org> writes:
> I find #000 on #fff too intense for large swaths of text.

Given that I think #333 is too dim but you think #000 is too intense, I
think it's fine not to merge this. I think we just fundamentally
disagree on this point.

I'm happy with the approach of installing a plugin on my side,
especially since, after I sent the patch in, I noticed that most other
sites use something closer to #333 than #000.

-- 
Kind regards
Yaseen Mowzer