From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id CD5C61F5AE; Mon, 17 May 2021 01:52:58 +0000 (UTC) Date: Mon, 17 May 2021 01:52:58 +0000 From: Eric Wong To: Yaseen Mowzer Cc: meta@public-inbox.org Subject: Re: [PATCH v2] contrib/css/216light: increase contrast of normal text Message-ID: <20210517015258.GA14414@dcvr> References: <20210516082059.1000966-1-yaseen@mowzer.co.za> <20210516084351.1157893-1-yaseen@mowzer.co.za> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210516084351.1157893-1-yaseen@mowzer.co.za> List-Id: Yaseen Mowzer wrote: > On my monitor #333 on #fff is a little bit hard to read. I think normal > text should just be #000. I wasn't completely sure about it, myself; but I can't stand light backgrounds in general floaters in my eyes are getting worse (AFAIK there's no treatment, either). > The head style uses the contrast between #333 and #000 for emphasis. To > preserve the emphasis `font-weight: bold` was added to the head style. > --- > > I changed my mind about the head style. I think we should make it bold > instead of loosing the emphasis. This is more consitent with what git > diff does. OK, more inline... > diff --git a/contrib/css/216light.css b/contrib/css/216light.css > index c66cfdfe..c68ca9ce 100644 > --- a/contrib/css/216light.css > +++ b/contrib/css/216light.css > @@ -4,7 +4,7 @@ > * Suitable for print, and blinding people with brightness. > * Haphazardly thrown together because bright colors hurt my eyes > */ > -* { background:#fff; color:#333 } > +* { background:#fff; color:#000 } I find #000 on #fff too intense for large swaths of text. Would #030 or #003 (dark green/blue) work for you? > /* > * Underlined links add visual noise which make them hard-to-read. > @@ -22,7 +22,7 @@ a:visited { color:#808 } > */ > *.add { color:#060 } > *.del {color:#900 } > -*.head { color:#000 } > +*.head { color:#000; font-weight:bold } I've been avoiding bold for stuff that might be important because some fonts or low-res displays make bold hard-to-read. Maybe something subtle like #300 work? Or keep it #000 if foreground becomes #030 or #003. (I think .head is the least important element to highlight by a long shot). > *.hunk { color:#960 } > > /*