From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] t/sigfd: use PublicInbox::DS::block_signals
Date: Thu, 6 May 2021 17:09:23 +0000 [thread overview]
Message-ID: <20210506170923.59604-1-e@80x24.org> (raw)
We already use PublicInbox::DS in this test and I've always
found the terminology of sig* APIs confusing :x
---
t/sigfd.t | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/t/sigfd.t b/t/sigfd.t
index 3a383d79..bb854147 100644
--- a/t/sigfd.t
+++ b/t/sigfd.t
@@ -6,15 +6,14 @@ use POSIX qw(:signal_h);
use Errno qw(ENOSYS);
use PublicInbox::Syscall qw(SFD_NONBLOCK);
require_ok 'PublicInbox::Sigfd';
+use PublicInbox::DS;
SKIP: {
if ($^O ne 'linux' && !eval { require IO::KQueue }) {
skip 'signalfd requires Linux or IO::KQueue to emulate', 10;
}
- my $new = POSIX::SigSet->new;
- $new->fillset or die "sigfillset: $!";
- my $old = POSIX::SigSet->new;
- sigprocmask(SIG_SETMASK, $new, $old) or die "sigprocmask $!";
+
+ my $old = PublicInbox::DS::block_signals();
my $hit = {};
my $sig = {};
local $SIG{HUP} = sub { $hit->{HUP}->{normal}++ };
@@ -25,7 +24,6 @@ SKIP: {
}
my $sigfd = PublicInbox::Sigfd->new($sig, 0);
if ($sigfd) {
- require PublicInbox::DS;
ok($sigfd, 'Sigfd->new works');
kill('HUP', $$) or die "kill $!";
kill('INT', $$) or die "kill $!";
reply other threads:[~2021-05-06 17:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506170923.59604-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).