* [PATCH] www: missing /$INBOX/$MSGID/raw returns 404
@ 2021-04-26 8:02 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2021-04-26 8:02 UTC (permalink / raw)
To: meta
Don't attempt to return HTTP 300 via Extmsg on it,
since whoever uses /raw is likely piping it to some
other command.
---
lib/PublicInbox/WWW.pm | 2 +-
t/plack.t | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index 456692a3..8f4bfd0f 100644
--- a/lib/PublicInbox/WWW.pm
+++ b/lib/PublicInbox/WWW.pm
@@ -272,7 +272,7 @@ sub get_index {
sub get_mid_txt {
my ($ctx) = @_;
require PublicInbox::Mbox;
- PublicInbox::Mbox::emit_raw($ctx) || r404($ctx);
+ PublicInbox::Mbox::emit_raw($ctx) || r(404);
}
# /$INBOX/$MESSAGE_ID/ -> HTML content (short quotes)
diff --git a/t/plack.t b/t/plack.t
index db72e6cc..40ff2baa 100644
--- a/t/plack.t
+++ b/t/plack.t
@@ -82,6 +82,8 @@ test_psgi($app, sub {
$res = $cb->(GET('http://example.com/test/crlf@example.com/raw'));
is($res->code, 200, 'retrieved CRLF raw');
like($res->content, qr/\r/, 'CR preserved in raw message');
+ $res = $cb->(GET('http://example.com/test/bogus@example.com/raw'));
+ is($res->code, 404, 'missing /raw is 404');
});
# redirect with newsgroup
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-04-26 8:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-26 8:02 [PATCH] www: missing /$INBOX/$MSGID/raw returns 404 Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).