From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 458401F5AE for ; Sat, 24 Apr 2021 10:23:30 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] extindex: --gc: use escape pathnames for SQL LIKE properly Date: Sat, 24 Apr 2021 10:23:30 +0000 Message-Id: <20210424102330.10527-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: This allows us to handle odd inboxes w/o a newsgroup configured if they also make the strange choice of having backslashes in their path name. Also, ensure we use case-sensitive LIKE, since case-insensitive FSes are not worth supporting. --- lib/PublicInbox/ExtSearchIdx.pm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm index a17e7579..9d6b3b9d 100644 --- a/lib/PublicInbox/ExtSearchIdx.pm +++ b/lib/PublicInbox/ExtSearchIdx.pm @@ -336,9 +336,11 @@ sub eidx_gc { $self->idx_init($opt); # acquire lock via V2Writable::_idx_init my $dbh = $self->{oidx}->dbh; + $dbh->do('PRAGMA case_sensitive_like = ON'); # only place we use LIKE my $x3_doc = $dbh->prepare('SELECT docid FROM xref3 WHERE ibx_id = ?'); my $ibx_ck = $dbh->prepare('SELECT ibx_id,eidx_key FROM inboxes'); - my $lc_i = $dbh->prepare('SELECT key FROM eidx_meta WHERE key LIKE ?'); + my $lc_i = $dbh->prepare(<<''); +SELECT key FROM eidx_meta WHERE key LIKE ? ESCAPE ? $ibx_ck->execute; while (my ($ibx_id, $eidx_key) = $ibx_ck->fetchrow_array) { @@ -354,8 +356,8 @@ DELETE FROM inboxes WHERE ibx_id = ? # drop last_commit info my $pat = $eidx_key; - $pat =~ s/([_%])/\\$1/g; - $lc_i->execute("lc-%:$pat//%"); + $pat =~ s/([_%\\])/\\$1/g; + $lc_i->execute("lc-%:$pat//%", '\\'); while (my ($key) = $lc_i->fetchrow_array) { next if $key !~ m!\Alc-v[1-9]+:\Q$eidx_key\E//!; warn "I: removing $key\n";