unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: t/lei-daemon.t failure when PERL_INLINE_DIRECTORY is set
Date: Tue, 20 Apr 2021 17:37:12 -0400	[thread overview]
Message-ID: <20210420213712.qfpftr2r543cqg7l@nitro.local> (raw)
In-Reply-To: <20210420203854.GA28776@dcvr>

On Tue, Apr 20, 2021 at 08:38:54PM +0000, Eric Wong wrote:
> > 	t/lei-daemon.t ............... 18/?
> > 	#   Failed test 'connect error noted'
> > 	#   at t/lei-daemon.t line 80.
> > 	#                   ''
> > 	#     doesn't match '(?^:\bconnect\()'
> > 	# Looks like you failed 1 test of 34.
> > 	t/lei-daemon.t ............... Dubious, test returned 1 (wstat 256, 0x100)
> > 
> > I'll be happy to help troubleshoot things, since I don't know how easy it
> > would be to reproduce this.
> 
> I can't seem to reproduce it on my end with CentOS 7 and
> libgit2-devel 0.26.8.  Try setting TEST_LEI_ERR_LOUD=1

While poking around, I've discovered that it only fails when "make test" runs
as root (don't judge -- this is in a throwaway lab VM):

	t/lei-daemon.t ............... 1/? # lei_err=/tmp/pi-lei-daemon-6667-ojwj/lei-daemon/xdg_run/lei/errors.log from previous run
	# phail

	#   Failed test 'connect error noted'
	#   at t/lei-daemon.t line 80.
	#                   ''
	#     doesn't match '(?^:\bconnect\()'
	# Looks like you failed 1 test of 34.
	t/lei-daemon.t ............... Dubious, test returned 1 (wstat 256, 0x100)
	Failed 1/34 subtests

When I run as a non-root user, it passes:

	t/lei-daemon.t ............... 1/? # lei_err=/tmp/pi-lei-daemon-11879-P3hC/lei-daemon/xdg_run/lei/errors.log from previous run
	# phail
	# lei_err=connect(/tmp/pi-lei-daemon-11879-P3hC/lei-daemon/xdg_run/lei/5.seq.sock): Permission denied at /home/mricon/public-inbox/blib/lib/PublicInbox/LEI.pm line 1073.
	# lei-daemon could not start, exited with $?=3328
	# connect(/tmp/pi-lei-daemon-11879-P3hC/lei-daemon/xdg_run/lei/5.seq.sock): Permission denied (after attempted daemon start)
	# Falling back to (slow) one-shot mode
	t/lei-daemon.t ............... ok

Hope that helps.

-K

  reply	other threads:[~2021-04-20 21:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20 20:33 t/lei-daemon.t failure when PERL_INLINE_DIRECTORY is set Konstantin Ryabitsev
2021-04-20 20:38 ` Eric Wong
2021-04-20 21:37   ` Konstantin Ryabitsev [this message]
2021-04-20 22:06     ` [PATCH] t/lei-daemon: skip inaccessible socket test as root Eric Wong
2021-04-21 15:03       ` Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210420213712.qfpftr2r543cqg7l@nitro.local \
    --to=konstantin@linuxfoundation.org \
    --cc=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).