From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/2] lei forget-search: new command to forget saved searches
Date: Tue, 20 Apr 2021 07:16:54 +0000 [thread overview]
Message-ID: <20210420071655.22700-2-e@80x24.org> (raw)
In-Reply-To: <20210420071655.22700-1-e@80x24.org>
Readers may lose interest in subscription topics. This lets
them avoid clutter by forgetting a saved search.
This does not and will not destroy the contents of an --output
mailbox. In other words, this is similar to unsubscribing
from an Atom/RSS feed or NNTP group.
I've also decided we won't support 'mv-search', since it'll
probably be rarely used and "lei convert" can be used, instead.
---
MANIFEST | 1 +
lib/PublicInbox/LEI.pm | 4 ++--
lib/PublicInbox/LeiForgetSearch.pm | 32 ++++++++++++++++++++++++++++++
t/lei-q-save.t | 11 ++++++++++
4 files changed, 46 insertions(+), 2 deletions(-)
create mode 100644 lib/PublicInbox/LeiForgetSearch.pm
diff --git a/MANIFEST b/MANIFEST
index f35c514c..d4055af4 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -191,6 +191,7 @@ lib/PublicInbox/LeiConvert.pm
lib/PublicInbox/LeiCurl.pm
lib/PublicInbox/LeiDedupe.pm
lib/PublicInbox/LeiExternal.pm
+lib/PublicInbox/LeiForgetSearch.pm
lib/PublicInbox/LeiHelp.pm
lib/PublicInbox/LeiImport.pm
lib/PublicInbox/LeiInit.pm
diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm
index c0385eb5..c3c79631 100644
--- a/lib/PublicInbox/LEI.pm
+++ b/lib/PublicInbox/LEI.pm
@@ -160,8 +160,8 @@ our %CMD = ( # sorted in order of importance/use:
'ls-search' => [ '[PREFIX]', 'list saved search queries',
qw(format|f=s pretty l ascii z|0), @c_opt ],
-'rm-query' => [ 'QUERY_NAME', 'remove a saved search', @c_opt ],
-'mv-query' => [ qw(OLD_NAME NEW_NAME), 'rename a saved search', @c_opt ],
+'forget-search' => [ 'OUTPUT', 'forget a saved search',
+ qw(verbose|v+), @c_opt ],
'plonk' => [ '--threads|--from=IDENT',
'exclude mail matching From: or threads from non-Message-ID searches',
diff --git a/lib/PublicInbox/LeiForgetSearch.pm b/lib/PublicInbox/LeiForgetSearch.pm
new file mode 100644
index 00000000..b5fe5fb1
--- /dev/null
+++ b/lib/PublicInbox/LeiForgetSearch.pm
@@ -0,0 +1,32 @@
+# Copyright (C) 2021 all contributors <meta@public-inbox.org>
+# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
+
+# "lei forget-search" forget/remove a saved search "lei q --save"
+package PublicInbox::LeiForgetSearch;
+use strict;
+use v5.10.1;
+use PublicInbox::LeiSavedSearch;
+use PublicInbox::LeiUp;
+use File::Path ();
+use SelectSaver;
+
+sub lei_forget_search {
+ my ($lei, $out) = @_;
+ my $d = PublicInbox::LeiSavedSearch::lss_dir_for($lei, \$out);
+ if (-e $d) {
+ my $save;
+ my $opt = { safe => 1 };
+ if ($lei->{opt}->{verbose}) {
+ $opt->{verbose} = 1;
+ $save = SelectSaver->new($lei->{2});
+ }
+ File::Path::remove_tree($d, $opt);
+ } else {
+ $lei->fail("--save was not used with $out cwd=".
+ $lei->rel2abs('.'));
+ }
+}
+
+*_complete_forget_search = \&PublicInbox::LeiUp::_complete_up;
+
+1;
diff --git a/t/lei-q-save.t b/t/lei-q-save.t
index 58342171..5a2f7fff 100644
--- a/t/lei-q-save.t
+++ b/t/lei-q-save.t
@@ -110,5 +110,16 @@ test_lei(sub {
like($mb, qr/<qp\@example\.com>/, 'new result written w/ -a');
lei_ok(qw(up --all=local));
+
+ ok(!lei(qw(forget-search), "$home/bogus"), 'bogus forget');
+ lei_ok qw(_complete lei forget-search);
+ like($lei_out, qr/mbrd-aug/, 'forget-search completion');
+ lei_ok(qw(forget-search -v), "$home/mbrd-aug");
+ is($lei_out, '', 'no output');
+ like($lei_err, qr/\bmbrd-aug\b/, '-v (verbose) reported unlinks');
+ lei_ok qw(_complete lei forget-search);
+ unlike($lei_out, qr/mbrd-aug/,
+ 'forget-search completion cleared after forget');
+ ok(!lei('up', "$home/mbrd-aug"), 'lei up fails after forget');
});
done_testing;
next prev parent reply other threads:[~2021-04-20 7:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 7:16 [PATCH 0/2] lei {edit,forget}-search Eric Wong
2021-04-20 7:16 ` Eric Wong [this message]
2021-04-20 7:16 ` [PATCH 2/2] lei edit-search: command to tweak search parameters Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420071655.22700-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).