From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/6] lei: support unlinked/missing saved searches
Date: Mon, 19 Apr 2021 08:52:10 +0000 [thread overview]
Message-ID: <20210419085215.14742-2-e@80x24.org> (raw)
In-Reply-To: <20210419085215.14742-1-e@80x24.org>
It's conceivable a user will want to erase all previous
results but still rerun/refresh a search to get new results.
We probably won't support prune functionality, here, and
instead require explicit removal of saved searches.
---
lib/PublicInbox/LeiSavedSearch.pm | 7 ++-----
t/lei-q-save.t | 7 +++++++
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/LeiSavedSearch.pm b/lib/PublicInbox/LeiSavedSearch.pm
index d67622c9..94920a4e 100644
--- a/lib/PublicInbox/LeiSavedSearch.pm
+++ b/lib/PublicInbox/LeiSavedSearch.pm
@@ -61,11 +61,8 @@ sub list {
bless $cfg, 'PublicInbox::Config';
my $out = $cfg->get_all('lei.q.output') or return ();
map {;
- if (s!\A(?:maildir|mh|mbox.+|mmdf):!!i) {
- -e $_ ? $_ : (); # TODO auto-prune somewhere?
- } else { # IMAP, maybe JMAP
- $_;
- }
+ s!\A(?:maildir|mh|mbox.+|mmdf):!!i;
+ $_;
} @$out
}
diff --git a/t/lei-q-save.t b/t/lei-q-save.t
index 761814b4..4e6ed642 100644
--- a/t/lei-q-save.t
+++ b/t/lei-q-save.t
@@ -67,5 +67,12 @@ test_lei(sub {
lei_ok qw(_complete lei up);
like($lei_out, qr!^\Q$home/mbcl2\E$!sm, 'complete got mbcl2 output');
like($lei_out, qr!^\Q$home/md/\E$!sm, 'complete got maildir output');
+
+ unlink("$home/mbcl2") or xbail "unlink $!";
+ lei_ok qw(_complete lei up);
+ like($lei_out, qr!^\Q$home/mbcl2\E$!sm,
+ 'mbcl2 output shown despite unlink');
+ lei_ok([qw(up mbcl2)], undef, { -C => $home, %$lei_opt });
+ ok(-f "$home/mbcl2" && -s _ == 0, 'up recreates on missing output');
});
done_testing;
next prev parent reply other threads:[~2021-04-19 8:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 8:52 [PATCH 0/6] lei saved search improvements Eric Wong
2021-04-19 8:52 ` Eric Wong [this message]
2021-04-19 8:52 ` [PATCH 2/6] lei q: implement import-before default for --save Eric Wong
2021-04-19 8:52 ` [PATCH 3/6] lei_saved_search: avoid needless var shadowing Eric Wong
2021-04-19 8:52 ` [PATCH 4/6] config: git_config_dump blesses Eric Wong
2021-04-19 8:52 ` [PATCH 5/6] lei_saved_search: split "lei q --save" and "lei up" init paths Eric Wong
2021-04-19 8:52 ` [PATCH 6/6] lei q: --save and --augment may be combined Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419085215.14742-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).