From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B03761F4B4; Tue, 13 Apr 2021 19:13:33 +0000 (UTC) Date: Tue, 13 Apr 2021 19:13:33 +0000 From: Eric Wong To: meta@public-inbox.org Subject: Re: [PATCH 4/5] lei q: start wiring up saved search Message-ID: <20210413191333.GA17484@dcvr> References: <20210413105446.7245-1-e@80x24.org> <20210413105446.7245-5-e@80x24.org> <20210413112518.GA7400@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210413112518.GA7400@dcvr> List-Id: Eric Wong wrote: > Eh, that should probably be "maxuid" since "num" is more > strongly associated with "NNTP article number". extindex may > only be easily exposed via IMAP and HTTP (since we Message-IDs > may conflict with different list trailers). Pushed with the following squashed in: diff --git a/lib/PublicInbox/LeiXSearch.pm b/lib/PublicInbox/LeiXSearch.pm index 7c540c1c..e1538391 100644 --- a/lib/PublicInbox/LeiXSearch.pm +++ b/lib/PublicInbox/LeiXSearch.pm @@ -159,7 +159,7 @@ sub query_one_mset { # for --threads and l2m w/o sort my $fl = $threads > 1 ? 1 : undef; my $lss = $lei->{dedupe}; $lss = undef unless $lss && $lss->can('cfg_set'); # saved search - my $maxk = "external.$dir.maxnum"; + my $maxk = "external.$dir.maxuid"; my $stop_at = $lss ? $lss->{-cfg}->{$maxk} : undef; if (defined $stop_at) { die "$maxk=$stop_at has multiple values" if ref $stop_at;