From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 2ED831F9F2 for ; Sat, 3 Apr 2021 10:48:28 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 3/5] lei tag: note message mismatches on failure Date: Sat, 3 Apr 2021 10:48:25 +0000 Message-Id: <20210403104827.17003-4-e@80x24.org> In-Reply-To: <20210403104827.17003-1-e@80x24.org> References: <20210403104827.17003-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Just exiting with a failure code and no error message is confusing :x --- lib/PublicInbox/LeiTag.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/LeiTag.pm b/lib/PublicInbox/LeiTag.pm index 06313139..c7a21c87 100644 --- a/lib/PublicInbox/LeiTag.pm +++ b/lib/PublicInbox/LeiTag.pm @@ -121,7 +121,8 @@ sub lei_tag { # the "lei tag" method sub note_missing { my ($self) = @_; - $self->{lei}->child_error(1 << 8) if $self->{missing}; + my $n = $self->{missing} or return; + $self->{lei}->child_error(1 << 8, "$n missed messages"); } sub ipc_atfork_child {