From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/5] lei tag: note message mismatches on failure
Date: Sat, 3 Apr 2021 10:48:25 +0000 [thread overview]
Message-ID: <20210403104827.17003-4-e@80x24.org> (raw)
In-Reply-To: <20210403104827.17003-1-e@80x24.org>
Just exiting with a failure code and no error message is
confusing :x
---
lib/PublicInbox/LeiTag.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/LeiTag.pm b/lib/PublicInbox/LeiTag.pm
index 06313139..c7a21c87 100644
--- a/lib/PublicInbox/LeiTag.pm
+++ b/lib/PublicInbox/LeiTag.pm
@@ -121,7 +121,8 @@ sub lei_tag { # the "lei tag" method
sub note_missing {
my ($self) = @_;
- $self->{lei}->child_error(1 << 8) if $self->{missing};
+ my $n = $self->{missing} or return;
+ $self->{lei}->child_error(1 << 8, "$n missed messages");
}
sub ipc_atfork_child {
next prev parent reply other threads:[~2021-04-03 10:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 10:48 [PATCH 0/5] lei/store: fix epoch roll, better errors Eric Wong
2021-04-03 10:48 ` [PATCH 1/5] lei_store: update alternates on new epoch Eric Wong
2021-04-03 10:48 ` [PATCH 2/5] test_common: lei_ok: improve diagnostics Eric Wong
2021-04-03 10:48 ` Eric Wong [this message]
2021-04-03 10:48 ` [PATCH 4/5] lei: improve handling of Message-ID-less draft messages Eric Wong
2021-04-03 10:48 ` [PATCH 5/5] lei/store: (more) synchronous non-fatal error output Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210403104827.17003-4-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).