From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 22DBD1FC97 for ; Sun, 28 Mar 2021 09:01:26 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 11/12] lei: drop coderepo placeholders, submodule TODO Date: Sun, 28 Mar 2021 09:01:23 +0000 Message-Id: <20210328090124.3541-12-e@80x24.org> In-Reply-To: <20210328090124.3541-1-e@80x24.org> References: <20210328090124.3541-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: "lei blob" supports --git-dir and -C, and checks if the current directory has a git directory associated with it. It will likely support submodules in the future. I'm inclined to believe declaring coderepos in a command-line tool is needless clutter and users will rarely want to search for blobs across different projects when on the command-line. --- lib/PublicInbox/LEI.pm | 9 --------- lib/PublicInbox/LeiBlob.pm | 1 + 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index a94941a9..8a07a4c8 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -172,15 +172,6 @@ our %CMD = ( # sorted in order of importance/use: 'remove imported messages from IMAP, Maildirs, and MH', qw(exact! all jobs:i indexed), @c_opt ], -# code repos are used for `show' to solve blobs from patch mails -'add-coderepo' => [ 'DIRNAME', 'add or set priority of a git code repo', - qw(boost=i), @c_opt ], -'ls-coderepo' => [ '[FILTER_TERMS...]', - 'list known code repos', qw(format|f=s z), @c_opt ], -'forget-coderepo' => [ 'DIRNAME', - 'stop using repo to solve blobs from patches', - qw(prune), @c_opt ], - 'add-watch' => [ 'LOCATION', 'watch for new messages and flag changes', qw(import! kw|keywords|flags! interval=s recursive|r exclude=s include=s), @c_opt ], diff --git a/lib/PublicInbox/LeiBlob.pm b/lib/PublicInbox/LeiBlob.pm index 8e610efd..91098a90 100644 --- a/lib/PublicInbox/LeiBlob.pm +++ b/lib/PublicInbox/LeiBlob.pm @@ -2,6 +2,7 @@ # License: AGPL-3.0+ # "lei blob $OID" command +# TODO: this doesn't scan submodules, but maybe it should package PublicInbox::LeiBlob; use strict; use v5.10.1;