From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 130ED1F9FF for ; Tue, 23 Mar 2021 11:48:09 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/5] test_common: check lei/errors.log Date: Tue, 23 Mar 2021 11:48:05 +0000 Message-Id: <20210323114808.7605-3-e@80x24.org> In-Reply-To: <20210323114808.7605-1-e@80x24.org> References: <20210323114808.7605-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: This will make it easier to diagnose some large internal rewrites. --- lib/PublicInbox/TestCommon.pm | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm index e67e94ea..d4117b6c 100644 --- a/lib/PublicInbox/TestCommon.pm +++ b/lib/PublicInbox/TestCommon.pm @@ -507,7 +507,7 @@ SKIP: { Socket::MsgHdr missing or Inline::C is unconfigured/missing EOM $lei_opt = { 1 => \$lei_out, 2 => \$lei_err }; - my ($daemon_pid, $for_destroy); + my ($daemon_pid, $for_destroy, $daemon_xrd); my $tmpdir = $test_opt->{tmpdir}; ($tmpdir, $for_destroy) = tmpdir unless $tmpdir; SKIP: { @@ -515,9 +515,9 @@ EOM my $home = "$tmpdir/lei-daemon"; mkdir($home, 0700) or BAIL_OUT "mkdir: $!"; local $ENV{HOME} = $home; - my $xrd = "$home/xdg_run"; - mkdir($xrd, 0700) or BAIL_OUT "mkdir: $!"; - local $ENV{XDG_RUNTIME_DIR} = $xrd; + $daemon_xrd = "$home/xdg_run"; + mkdir($daemon_xrd, 0700) or BAIL_OUT "mkdir: $!"; + local $ENV{XDG_RUNTIME_DIR} = $daemon_xrd; $cb->(); lei_ok(qw(daemon-pid), \"daemon-pid after $t"); chomp($daemon_pid = $lei_out); @@ -547,6 +547,11 @@ EOM tick; } ok(!kill(0, $daemon_pid), "$t daemon stopped after oneshot"); + my $f = "$daemon_xrd/lei/errors.log"; + open my $fh, '<', $f or BAIL_OUT "$f: $!"; + my @l = <$fh>; + is_deeply(\@l, [], + "$t daemon XDG_RUNTIME_DIR/lei/errors.log empty"); } }; # SKIP if missing git 2.6+ || Xapian || SQLite || json } # /test_lei