From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] examples: cgit-commit-filter: drop <tt> HTML tag, use title=
Date: Fri, 19 Mar 2021 04:18:54 +0000 [thread overview]
Message-ID: <20210319041854.17213-1-e@80x24.org> (raw)
<tt> doesn't seem necessary and it's deprecated in HTML, nowadays.
In any case, dillo's CSS support seems to show it as fixed-width
even without <tt>. Use the title= attribute to highlight that
it goes to the mail thread, too.
In the future, we'll probably link to something like "lei p2q"
(patch-to-query) to include OIDs in the search.
---
examples/cgit-commit-filter.lua | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/examples/cgit-commit-filter.lua b/examples/cgit-commit-filter.lua
index 9614c944..9857b3c9 100644
--- a/examples/cgit-commit-filter.lua
+++ b/examples/cgit-commit-filter.lua
@@ -31,12 +31,13 @@ function filter_close()
if u == nil then
html(buffer)
else
- html('<a href="' .. u .. '?x=t&q=')
+ html("<a\ntitle='mail thread'\n")
+ html('href="' .. u .. '?x=t&q=')
s = string.gsub(buffer, '"', '""')
html_url_arg('"' .. s .. '"')
- html('"><tt>')
+ html('">')
html_txt(buffer)
- html('</tt></a>')
+ html('</a>')
end
else
-- pass the body-through as-is
reply other threads:[~2021-03-19 4:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319041854.17213-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).