* [PATCH] searchview: collapse Message-ID links in summary
@ 2021-03-17 18:14 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2021-03-17 18:14 UTC (permalink / raw)
To: meta; +Cc: Konstantin Ryabitsev
There's no point in showing duplicate links to the same
Message-ID in summary view. The per-message page will
note the duplication (if any) separately.
Reported-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Link: https://public-inbox.org/meta/20210317132723.xx4klonordhsb6ve@chatter.i7.local/
---
lib/PublicInbox/SearchView.pm | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index 2d0b8e13..e13359d5 100644
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -98,11 +98,9 @@ sub mset_summary {
my $obfs_ibx = $ibx->{obfuscate} ? $ibx : undef;
my @nums = @{$ibx->isrch->mset_to_artnums($mset)};
my %num2msg = map { $_->{num} => $_ } @{$ibx->over->get_all(@nums)};
- my ($min, $max);
+ my ($min, $max, %seen);
foreach my $m ($mset->items) {
- my $rank = sprintf("%${pad}d", $m->get_rank + 1);
- my $pct = get_pct($m);
my $num = shift @nums;
my $smsg = delete($num2msg{$num}) or do {
eval {
@@ -111,7 +109,12 @@ sub mset_summary {
};
next;
};
+ my $mid = $smsg->{mid};
+ next if $seen{$mid}++;
+ $mid = mid_href($mid);
$ctx->{-t_max} //= $smsg->{ts};
+ my $rank = sprintf("%${pad}d", $m->get_rank + 1);
+ my $pct = get_pct($m);
# only when sorting by relevance, ->items is always
# ordered descending:
@@ -125,7 +128,6 @@ sub mset_summary {
obfuscate_addrs($obfs_ibx, $f);
}
my $date = fmt_ts($smsg->{ds});
- my $mid = mid_href($smsg->{mid});
$s = '(no subject)' if $s eq '';
$$res .= qq{$rank. <b><a\nhref="$mid/">}.
$s . "</a></b>\n";
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-17 18:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-17 18:14 [PATCH] searchview: collapse Message-ID links in summary Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).