From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 9D5071F9FF for ; Tue, 16 Mar 2021 01:43:45 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/2] lei_store: remove maildir_keywords Date: Tue, 16 Mar 2021 07:43:45 +0600 Message-Id: <20210316014345.24569-3-e@80x24.org> In-Reply-To: <20210316014345.24569-1-e@80x24.org> References: <20210316014345.24569-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: It's redundant and the same functionality is in MdirReader. --- lib/PublicInbox/LeiStore.pm | 8 -------- t/lei_store.t | 6 ------ 2 files changed, 14 deletions(-) diff --git a/lib/PublicInbox/LeiStore.pm b/lib/PublicInbox/LeiStore.pm index 10fa9c54..771443db 100644 --- a/lib/PublicInbox/LeiStore.pm +++ b/lib/PublicInbox/LeiStore.pm @@ -159,14 +159,6 @@ sub remove_eml_keywords { \@docids; } -# TODO: move this to MdirReader, maybe... -# cf: https://cr.yp.to/proto/maildir.html -my %c2kw = ('D' => 'draft', F => 'flagged', R => 'answered', S => 'seen'); -sub maildir_keywords { - $_[-1] =~ /:2,([A-Z]+)\z/i ? - sort(map { $c2kw{$_} // () } split(//, $1)) : (); -} - sub add_eml { my ($self, $eml, @kw) = @_; my $im = $self->importer; # may create new epoch diff --git a/t/lei_store.t b/t/lei_store.t index 258db25a..d270e1f6 100644 --- a/t/lei_store.t +++ b/t/lei_store.t @@ -21,12 +21,6 @@ like($smsg->{blob}, qr/\A[0-9a-f]+\z/, 'add returned OID'); my $eml = eml_load('t/data/0001.patch'); is($sto->add_eml($eml), undef, 'idempotent'); $sto->done; -is_deeply([$sto->maildir_keywords('/foo:2,')], [], 'Maildir no keywords'); -is_deeply([$sto->maildir_keywords('/foo:2,S')], ['seen'], 'Maildir seen'); -is_deeply([$sto->maildir_keywords('/foo:2,RS')], ['answered', 'seen'], - 'Maildir answered + seen'); -is_deeply([$sto->maildir_keywords('/foo:2,RSZ')], ['answered', 'seen'], - 'Maildir answered + seen w/o Z'); { my $es = $sto->search; my $msgs = $es->over->query_xover(0, 1000);