From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 5/7] imapclient: disable workaround for Mail::IMAPClient 3.43+
Date: Thu, 11 Mar 2021 02:45:36 -0800 [thread overview]
Message-ID: <20210311104538.7743-6-e@80x24.org> (raw)
In-Reply-To: <20210311104538.7743-1-e@80x24.org>
These fixes are in the recently-released Mail::IMAPClient 3.43:
https://metacpan.org/source/PLOBBES/Mail-IMAPClient-3.43/Changes
---
lib/PublicInbox/IMAPClient.pm | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/IMAPClient.pm b/lib/PublicInbox/IMAPClient.pm
index 33deee9e..945b10fa 100644
--- a/lib/PublicInbox/IMAPClient.pm
+++ b/lib/PublicInbox/IMAPClient.pm
@@ -4,17 +4,18 @@
#
# The license for this file differs from the rest of public-inbox.
#
-# Workaround some bugs in upstream Mail::IMAPClient when
+# Workaround some bugs in upstream Mail::IMAPClient <= 3.42 when
# compression is enabled:
# - reference cycle: https://rt.cpan.org/Ticket/Display.html?id=132654
# - read starvation: https://rt.cpan.org/Ticket/Display.html?id=132720
package PublicInbox::IMAPClient;
use strict;
use parent 'Mail::IMAPClient';
-use Errno qw(EAGAIN);
+unless (eval('use Mail::IMAPClient 3.43')) {
+require Errno;
# RFC4978 COMPRESS
-sub compress {
+*compress = sub {
my ($self) = @_;
# BUG? strict check on capability commented out for now...
@@ -101,7 +102,7 @@ sub compress {
# I/O readiness notifications (select, poll). Refactoring
# callers will be needed in the unlikely case somebody wants
# to use edge-triggered notifications (EV_CLEAR, EPOLLET).
- $! = EAGAIN;
+ $! = Errno::EAGAIN();
return undef;
}
@@ -114,6 +115,7 @@ sub compress {
};
return $self;
-}
+};
+} # $Mail::IMAPClient::VERSION < 3.43
1;
next prev parent reply other threads:[~2021-03-11 10:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 10:45 [PATCH 0/7] doc updates, fixups, and more Eric Wong
2021-03-11 10:45 ` [PATCH 1/7] doc: glossary: add information for dates and timestamps Eric Wong
2021-03-11 10:45 ` [PATCH 2/7] searchidx: remove smsg_from_doc Eric Wong
2021-03-11 10:45 ` [PATCH 3/7] lei_curl: note proposed master/client mode for curl Eric Wong
2021-03-11 10:45 ` [PATCH 4/7] doc: update 1.7 release notes, tuning, TODO Eric Wong
2021-03-11 10:45 ` Eric Wong [this message]
2021-03-11 20:34 ` [SQUASH] imapclient: disable workaround for Mail::IMAPClient 3.43+ Eric Wong
2021-03-11 10:45 ` [PATCH 6/7] config: use '-f' key to store config file pathname Eric Wong
2021-03-11 10:45 ` [PATCH 7/7] v2writable: fix undocumented --xapian-only Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311104538.7743-6-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).