From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id D08A91FA01 for ; Wed, 10 Mar 2021 13:23:45 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 3/5] lei import: simplify Maildir handling Date: Wed, 10 Mar 2021 13:23:43 +0000 Message-Id: <20210310132345.28283-4-e@80x24.org> In-Reply-To: <20210310132345.28283-1-e@80x24.org> References: <20210310132345.28283-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Having a one-off Maildir functionality in LeiStore doesn't seem worth the maintenance burden, especially given an upcoming change to skip trashed messages. I expect this will hurt performance slightly with extra IPC overhead for the socket copy, but "lei import" may eventually become rare or at least not hit messages redundantly. --- lib/PublicInbox/LeiImport.pm | 8 ++++---- lib/PublicInbox/LeiStore.pm | 6 ------ 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/lib/PublicInbox/LeiImport.pm b/lib/PublicInbox/LeiImport.pm index 23cecd53..815788b3 100644 --- a/lib/PublicInbox/LeiImport.pm +++ b/lib/PublicInbox/LeiImport.pm @@ -147,9 +147,9 @@ error reading $input: $! $lei->child_error(1 << 8, "$input: $@") if $@; } -sub _import_maildir { # maildir_each_file cb - my ($f, $sto, $set_kw) = @_; - $sto->ipc_do('set_eml_from_maildir', $f, $set_kw); +sub _import_maildir { # maildir_each_eml cb + my ($f, $kw, $eml, $sto, $set_kw) = @_; + $sto->ipc_do('set_eml', $eml, $set_kw ? @$kw : ()); } sub _import_net { # imap_each, nntp_each cb @@ -181,7 +181,7 @@ sub import_path_url { return $lei->fail(<{sto}, $lei->{opt}->{kw}); } else { diff --git a/lib/PublicInbox/LeiStore.pm b/lib/PublicInbox/LeiStore.pm index 92c29100..6ace2ad1 100644 --- a/lib/PublicInbox/LeiStore.pm +++ b/lib/PublicInbox/LeiStore.pm @@ -213,12 +213,6 @@ sub set_eml { add_eml($self, $eml, @kw) // set_eml_keywords($self, $eml, @kw); } -sub set_eml_from_maildir { - my ($self, $f, $set_kw) = @_; - my $eml = eml_from_path($f) or return; - set_eml($self, $eml, $set_kw ? maildir_keywords($f) : ()); -} - sub checkpoint { my ($self, $wait) = @_; if (my $im = $self->{im}) {