* [PATCH] lei: completion: bash: generalize nospace usage
@ 2021-02-18 12:27 Eric Wong
2021-02-25 10:33 ` better "compopt -o nospace" ideas? [was: lei: completion: bash: generalize nospace usage] Eric Wong
0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2021-02-18 12:27 UTC (permalink / raw)
To: meta
We'll be completing more options with ':', '//' and '=' in the
future, so make it easier to disable trailing spaces on
completions.
---
contrib/completion/lei-completion.bash | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/contrib/completion/lei-completion.bash b/contrib/completion/lei-completion.bash
index 619805fb..2c28d44a 100644
--- a/contrib/completion/lei-completion.bash
+++ b/contrib/completion/lei-completion.bash
@@ -4,14 +4,12 @@
# preliminary bash completion support for lei (Local Email Interface)
# Needs a lot of work, see `lei__complete' in lib/PublicInbox::LEI.pm
_lei() {
- case ${COMP_WORDS[@]} in
- *' add-external h'* | *' --mirror h'*)
- compopt -o nospace
- ;;
+ local wordlist="$(lei _complete ${COMP_WORDS[@]})"
+ case $wordlist in
+ *':'* | *'='* | '//'*) compopt -o nospace ;;
*) compopt +o nospace ;; # the default
esac
- COMPREPLY=($(compgen -W "$(lei _complete ${COMP_WORDS[@]})" \
- -- "${COMP_WORDS[COMP_CWORD]}"))
+ COMPREPLY=($(compgen -W "$wordlist" -- "${COMP_WORDS[COMP_CWORD]}"))
return 0
}
complete -o default -o bashdefault -F _lei lei
^ permalink raw reply related [flat|nested] 2+ messages in thread
* better "compopt -o nospace" ideas? [was: lei: completion: bash: generalize nospace usage]
2021-02-18 12:27 [PATCH] lei: completion: bash: generalize nospace usage Eric Wong
@ 2021-02-25 10:33 ` Eric Wong
0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2021-02-25 10:33 UTC (permalink / raw)
To: meta
Eric Wong <e@80x24.org> wrote:
> We'll be completing more options with ':', '//' and '=' in the
> future, so make it easier to disable trailing spaces on
> completions.
<snip>
> +++ b/contrib/completion/lei-completion.bash
> @@ -4,14 +4,12 @@
> # preliminary bash completion support for lei (Local Email Interface)
> # Needs a lot of work, see `lei__complete' in lib/PublicInbox::LEI.pm
> _lei() {
> - case ${COMP_WORDS[@]} in
> - *' add-external h'* | *' --mirror h'*)
> - compopt -o nospace
> - ;;
> + local wordlist="$(lei _complete ${COMP_WORDS[@]})"
> + case $wordlist in
> + *':'* | *'='* | '//'*) compopt -o nospace ;;
While this is nicer than before, I'm still wondering if there's
a better way for lei to communicate "-o nospace" to bash...
(or similar options for other shells)
Thanks in advance for any ideas you might provide.
> *) compopt +o nospace ;; # the default
> esac
> - COMPREPLY=($(compgen -W "$(lei _complete ${COMP_WORDS[@]})" \
> - -- "${COMP_WORDS[COMP_CWORD]}"))
> + COMPREPLY=($(compgen -W "$wordlist" -- "${COMP_WORDS[COMP_CWORD]}"))
> return 0
> }
> complete -o default -o bashdefault -F _lei lei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-25 10:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-18 12:27 [PATCH] lei: completion: bash: generalize nospace usage Eric Wong
2021-02-25 10:33 ` better "compopt -o nospace" ideas? [was: lei: completion: bash: generalize nospace usage] Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).