unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: better "compopt -o nospace" ideas? [was: lei: completion: bash: generalize nospace usage]
Date: Thu, 25 Feb 2021 10:33:39 +0000	[thread overview]
Message-ID: <20210225103339.GA12705@dcvr> (raw)
In-Reply-To: <20210218122709.18097-1-e@80x24.org>

Eric Wong <e@80x24.org> wrote:
> We'll be completing more options with ':', '//' and '=' in the
> future, so make it easier to disable trailing spaces on
> completions.

<snip>

> +++ b/contrib/completion/lei-completion.bash
> @@ -4,14 +4,12 @@
>  # preliminary bash completion support for lei (Local Email Interface)
>  # Needs a lot of work, see `lei__complete' in lib/PublicInbox::LEI.pm
>  _lei() {
> -	case ${COMP_WORDS[@]} in
> -	*' add-external h'* | *' --mirror h'*)
> -		compopt -o nospace
> -		;;
> +	local wordlist="$(lei _complete ${COMP_WORDS[@]})"
> +	case $wordlist in
> +	*':'* | *'='* | '//'*) compopt -o nospace ;;

While this is nicer than before, I'm still wondering if there's
a better way for lei to communicate "-o nospace" to bash...
(or similar options for other shells)

Thanks in advance for any ideas you might provide.

>  	*) compopt +o nospace ;; # the default
>  	esac
> -	COMPREPLY=($(compgen -W "$(lei _complete ${COMP_WORDS[@]})" \
> -			-- "${COMP_WORDS[COMP_CWORD]}"))
> +	COMPREPLY=($(compgen -W "$wordlist" -- "${COMP_WORDS[COMP_CWORD]}"))
>  	return 0
>  }
>  complete -o default -o bashdefault -F _lei lei

      reply	other threads:[~2021-02-25 10:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 12:27 [PATCH] lei: completion: bash: generalize nospace usage Eric Wong
2021-02-25 10:33 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210225103339.GA12705@dcvr \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).