* [PATCH v2] www: use PublicInbox::WwwStream
@ 2021-02-24 8:54 Uwe Kleine-König
2021-02-24 9:47 ` Eric Wong
0 siblings, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2021-02-24 8:54 UTC (permalink / raw)
To: meta
This prevents the following problem logged to the webserver's error log:
E: Undefined subroutine &PublicInbox::WwwStream::code_footer called at /usr/share/perl5/PublicInbox/WwwListing.pm line 102.
in PublicInbox::ConfigIter=ARRAY(0x557aea68b1a8)::each_section at /usr/share/perl5/PublicInbox/ConfigIter.pm line 37.
Fixes: 7a3946ef122e ("www: support listing of inboxes")
---
Hello,
I fatfingered an additional ; in the (implicit) v1. :-\
Best regards
Uwe
lib/PublicInbox/WwwListing.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/PublicInbox/WwwListing.pm b/lib/PublicInbox/WwwListing.pm
index d58618ccc01f..f28eddf1abb7 100644
--- a/lib/PublicInbox/WwwListing.pm
+++ b/lib/PublicInbox/WwwListing.pm
@@ -9,6 +9,7 @@ use PublicInbox::Hval qw(prurl fmt_ts);
use PublicInbox::Linkify;
use PublicInbox::GzipFilter qw(gzf_maybe);
use PublicInbox::ConfigIter;
+use PublicInbox::WwwStream;
use bytes (); # bytes::length
sub ibx_entry {
--
2.30.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] www: use PublicInbox::WwwStream
2021-02-24 8:54 [PATCH v2] www: use PublicInbox::WwwStream Uwe Kleine-König
@ 2021-02-24 9:47 ` Eric Wong
2021-02-24 10:17 ` Uwe Kleine-König
0 siblings, 1 reply; 4+ messages in thread
From: Eric Wong @ 2021-02-24 9:47 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: meta
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> This prevents the following problem logged to the webserver's error log:
>
> E: Undefined subroutine &PublicInbox::WwwStream::code_footer called at /usr/share/perl5/PublicInbox/WwwListing.pm line 102.
> in PublicInbox::ConfigIter=ARRAY(0x557aea68b1a8)::each_section at /usr/share/perl5/PublicInbox/ConfigIter.pm line 37.
Thanks, I tend to miss these errors since there's preloading
everywhere in tests to avoid startup penalties :x
> Fixes: 7a3946ef122e ("www: support listing of inboxes")
> ---
> Hello,
>
> I fatfingered an additional ; in the (implicit) v1. :-\
No worries, applied and pushed as a5af0bd94dc0504ec34d49199eb2b7d39ceb8557
Thanks again.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] www: use PublicInbox::WwwStream
2021-02-24 9:47 ` Eric Wong
@ 2021-02-24 10:17 ` Uwe Kleine-König
2021-02-24 10:53 ` Eric Wong
0 siblings, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2021-02-24 10:17 UTC (permalink / raw)
To: Eric Wong; +Cc: meta
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
On Wed, Feb 24, 2021 at 09:47:50AM +0000, Eric Wong wrote:
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> > This prevents the following problem logged to the webserver's error log:
> >
> > E: Undefined subroutine &PublicInbox::WwwStream::code_footer called at /usr/share/perl5/PublicInbox/WwwListing.pm line 102.
> > in PublicInbox::ConfigIter=ARRAY(0x557aea68b1a8)::each_section at /usr/share/perl5/PublicInbox/ConfigIter.pm line 37.
>
> Thanks, I tend to miss these errors since there's preloading
> everywhere in tests to avoid startup penalties :x
>
> > Fixes: 7a3946ef122e ("www: support listing of inboxes")
> > ---
> > Hello,
> >
> > I fatfingered an additional ; in the (implicit) v1. :-\
>
> No worries, applied and pushed as a5af0bd94dc0504ec34d49199eb2b7d39ceb8557
> Thanks again.
Great, note this is also relevant for the stable-1.6 branch.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] www: use PublicInbox::WwwStream
2021-02-24 10:17 ` Uwe Kleine-König
@ 2021-02-24 10:53 ` Eric Wong
0 siblings, 0 replies; 4+ messages in thread
From: Eric Wong @ 2021-02-24 10:53 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: meta
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> On Wed, Feb 24, 2021 at 09:47:50AM +0000, Eric Wong wrote:
> > No worries, applied and pushed as a5af0bd94dc0504ec34d49199eb2b7d39ceb8557
>
> Great, note this is also relevant for the stable-1.6 branch.
Ah, yes, already forgot about that :x Pushed there, too. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-24 10:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-24 8:54 [PATCH v2] www: use PublicInbox::WwwStream Uwe Kleine-König
2021-02-24 9:47 ` Eric Wong
2021-02-24 10:17 ` Uwe Kleine-König
2021-02-24 10:53 ` Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).