From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 4E4C61F9FD;
	Wed, 24 Feb 2021 09:47:50 +0000 (UTC)
Date: Wed, 24 Feb 2021 09:47:50 +0000
From: Eric Wong <e@80x24.org>
To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc: meta@public-inbox.org
Subject: Re: [PATCH v2] www: use PublicInbox::WwwStream
Message-ID: <20210224094750.GA26757@dcvr>
References: <20210224085456.77928-1-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210224085456.77928-1-u.kleine-koenig@pengutronix.de>
List-Id: <meta.public-inbox.org>

Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> This prevents the following problem logged to the webserver's error log:
> 
> 	E: Undefined subroutine &PublicInbox::WwwStream::code_footer called at /usr/share/perl5/PublicInbox/WwwListing.pm line 102.
> 	 in PublicInbox::ConfigIter=ARRAY(0x557aea68b1a8)::each_section at /usr/share/perl5/PublicInbox/ConfigIter.pm line 37.

Thanks, I tend to miss these errors since there's preloading
everywhere in tests to avoid startup penalties :x

> Fixes: 7a3946ef122e ("www: support listing of inboxes")
> ---
> Hello,
> 
> I fatfingered an additional ; in the (implicit) v1. :-\

No worries, applied and pushed as a5af0bd94dc0504ec34d49199eb2b7d39ceb8557
Thanks again.