From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C829B1F9FD for ; Mon, 22 Feb 2021 14:05:30 +0000 (UTC) Received: by mail-qv1-xf35.google.com with SMTP id dg2so3897665qvb.12 for ; Mon, 22 Feb 2021 06:05:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=EuPNPjdzcOFgJcJZsysudZf/OjQYHBj30f00j1e2cms=; b=TXA7+zP+MzkHAIWGXeajxJr2KvKzWiY980ukBWUv8CK1f2LIzczJ+yZKdVuamIrZ4s ++DAzMxBrWi3NJthBeuy+6iVqIjgPglsgS9ijPxtn+MmAI3py0nVvjLAiLNdMbrHb6Cu hj5RwHHRF3U97xiDmKGGVoePpQgiGtxKs+p6o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=EuPNPjdzcOFgJcJZsysudZf/OjQYHBj30f00j1e2cms=; b=VIuLEQhHFtS3jTEjdDx4MQfz6utUvIRHpf0zmlih218pvFLO9D4IOtpSo14mBWHt3V 6XoHbhLaP4A+dhOvZutkYWZcwCaifv34JgmRiFiMbxa/3rxKv9CiSRvc6CoSNROpAS2g RcEGWQzuve3yP/ovjqN1JuMKo+n3hcOR7/4s1+YF/S9j7y8HYl1UCjXYY7R+9bQjC3Xh BIce7/VbbHEMBXEDMqBrizprkLEKOsNO5nCBL224VXmdnfjj6Wcd6gVbJG8kHYLXA0iy z8qbkDMA+Kcs7iKNpyTr8b2/nCgUMnKf1jPRw4MEDF8o82UM4S/2zhNHjHwwVXI3pbJl o7uQ== X-Gm-Message-State: AOAM533mG9SYqq8brOF4F/ODpChPktYxMlEnHV+RM1f2jccFQtBhQISI cbPZLl3Lc6GQEqV54qym4o629w== X-Google-Smtp-Source: ABdhPJymqRiFHKQCcdmaCPveyvYRRDW8byC+Yp9AYyNcFkP8aNz6VOwI2ypP/SsKHimVi0lejwy/vw== X-Received: by 2002:a0c:b20d:: with SMTP id x13mr20616596qvd.19.1614002729519; Mon, 22 Feb 2021 06:05:29 -0800 (PST) Received: from chatter.i7.local ([89.36.78.230]) by smtp.gmail.com with ESMTPSA id t54sm11123956qte.8.2021.02.22.06.05.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Feb 2021 06:05:28 -0800 (PST) Date: Mon, 22 Feb 2021 09:05:26 -0500 From: Konstantin Ryabitsev To: Eric Wong Cc: Kyle Meyer , meta@public-inbox.org Subject: Re: [PATCH 3/3] t/www_listing: require grok-pull version 2 or later Message-ID: <20210222140526.7iqivx3z522wvguk@chatter.i7.local> Mail-Followup-To: Eric Wong , Kyle Meyer , meta@public-inbox.org References: <20210221214612.15071-1-kyle@kyleam.com> <20210221214612.15071-4-kyle@kyleam.com> <20210221222013.GA31960@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210221222013.GA31960@dcvr> List-Id: On Sun, Feb 21, 2021 at 10:20:13PM +0000, Eric Wong wrote: > > This was tested with the latest release of Grokmirror, v2.0.7. Note > > that the "pull" and "fsck" sections are required even though they're > > empty. Hmm... That grok-pull requires the [fsck] section is a bug that I introduced in one of the last versions. :/ I'll put in a fix that doesn't require it. > > Another option would be to generate an appropriate v1 or v2 > > configuration based on which Grokmirror version is detected. I'm > > not sure that's worth the trouble though. > > Ugh, some of these incompatible changes to grokmirror are really > annoying and will break existing scripts when I upgrade. > (and I suspect this affects other people, too). Grokmirror-1.x is not maintained any more and 2.x is a much better codebase anyway. It was a difficult call to introduce a config change that intentionally breaks upgrade path from 1.x to 2.x, but the priority was to avoid a much bigger problem by sneaking this upgrade on an unsuspecting repo admin. Grokmirror-2 completely refactors how backend repositories are organized, so the first grok-fsck run on large repo collections with a lot of alternates could have had potentially led to a disastrous outcome resulting in repository corruption. Not a problem for repos on lore.kernel.org where there are no forks, but very much a problem for git.kernel.org and source.codeaurora.org mirrors (especially the latter). So, I had to make the choice between annoyance and potential corruption. :) The breaking nature of the change is documented in https://git.sr.ht/~monsieuricon/grokmirror/tree/master/item/UPGRADING.rst > > xsys($grok_pull, '-c', "$tmpdir/repos.conf"); > > - is($? >> 8, 127, 'grok-pull exit code as expected'); > > + is($? >> 8, 0, 'grok-pull exit code as expected'); > > In particular, I'm relying on this exit code in at least one of > my scripts. Now I'll have to RTFM to figure out if I should be > testing any other exit codes or something else... I'm pretty sure I did this to make grok-pull work better with systemd, sorry. -K