unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: Kyle Meyer <kyle@kyleam.com>
Cc: meta@public-inbox.org
Subject: Re: [PATCH 1/3] t/www_listing: correct the number of tests for grok-pull skip
Date: Sun, 21 Feb 2021 22:02:39 +0000	[thread overview]
Message-ID: <20210221220239.GA24690@dcvr> (raw)
In-Reply-To: <20210221214612.15071-2-kyle@kyleam.com>

Kyle Meyer <kyle@kyleam.com> wrote:
> ---
> 
>   I'm not positive that I'm understanding skip's $how_many argument or
>   that it matters much.

It doesn't seem to matter, anymore.

In the old days, Test::More required explicit plan test counts
for everything, but we've always relied on done_testing() (no
args) in our code base with no explicit plan.

I've given up maintaining counts inside test_lei; and
just using `1'.  I suppose it's safe to do for the rest
of our tests, but I'm not against this patch, either.

  reply	other threads:[~2021-02-21 22:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-21 21:46 [PATCH 0/3] t/www_listing: update for Grokmirror v2 Kyle Meyer
2021-02-21 21:46 ` [PATCH 1/3] t/www_listing: correct the number of tests for grok-pull skip Kyle Meyer
2021-02-21 22:02   ` Eric Wong [this message]
2021-02-21 21:46 ` [PATCH 2/3] t/www_listing: reword grok-pull skip message Kyle Meyer
2021-02-21 21:46 ` [PATCH 3/3] t/www_listing: require grok-pull version 2 or later Kyle Meyer
2021-02-21 22:20   ` Eric Wong
2021-02-22 14:05     ` Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210221220239.GA24690@dcvr \
    --to=e@80x24.org \
    --cc=kyle@kyleam.com \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).