From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 0/2] WWW + "lei q --stdin": support git approxidate
Date: Wed, 10 Feb 2021 18:57:57 -0100 [thread overview]
Message-ID: <20210210195759.11108-1-e@80x24.org> (raw)
1/2 is something I've wanted since 2015. It could be done in a
less janky way if we didn't have to spawn git-rev-parse(1)
(libgit2 doesn't expose git__date_parse) AND if we didn't need
to support both XS and SWIG Xapian bindings.
But it's stable enough performance-wise for now with a single
git(1) process that I don't worry about making it public-facing
in WWW.
I'm not completely sure about 2/2, but I figure lei maintaining
consistency with WWW is slightly more important that consistency
with git (and git doesn't use mairix-like prefixes :P).
I also don't want to muck around too much with how Xapian does
quoted phrases
Eric Wong (2):
search: use git approxidate in WWW and "lei q --stdin"
search: disallow spaces in argv approxidate queries
lib/PublicInbox/Isearch.pm | 1 +
lib/PublicInbox/LeiQuery.pm | 8 +++++++-
lib/PublicInbox/Mbox.pm | 1 +
lib/PublicInbox/Search.pm | 37 ++++++++++++++++++++++++++---------
lib/PublicInbox/SearchView.pm | 3 ++-
t/lei-externals.t | 2 +-
t/psgi_search.t | 37 ++++++++++++++++++++---------------
t/search.t | 25 +++++++++++++++++++++++
8 files changed, 86 insertions(+), 28 deletions(-)
next reply other threads:[~2021-02-10 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 19:57 Eric Wong [this message]
2021-02-10 19:57 ` [PATCH 1/2] search: use git approxidate in WWW and "lei q --stdin" Eric Wong
2021-02-11 1:09 ` [SQUASH 3/2] t/search.t: fix offset error Eric Wong
2021-02-10 19:57 ` [RFC 2/2] search: disallow spaces in argv approxidate queries Eric Wong
2021-02-12 4:34 ` [PATCH 0/2] WWW + "lei q --stdin": support git approxidate Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210195759.11108-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).