From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/6] lei_external: remove unnecessary Exporter use
Date: Wed, 10 Feb 2021 07:07:45 +0000 [thread overview]
Message-ID: <20210210070749.30391-3-e@80x24.org> (raw)
In-Reply-To: <20210210070749.30391-1-e@80x24.org>
We don't need to export for methods which are only called via
"->" or "->can".
---
lib/PublicInbox/LeiExternal.pm | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/PublicInbox/LeiExternal.pm b/lib/PublicInbox/LeiExternal.pm
index bac15226..b4e1918d 100644
--- a/lib/PublicInbox/LeiExternal.pm
+++ b/lib/PublicInbox/LeiExternal.pm
@@ -5,8 +5,6 @@
package PublicInbox::LeiExternal;
use strict;
use v5.10.1;
-use parent qw(Exporter);
-our @EXPORT = qw(lei_ls_external lei_add_external lei_forget_external);
use PublicInbox::Config;
sub externals_each {
next prev parent reply other threads:[~2021-02-10 7:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 7:07 [PATCH 0/6] more lei stuffs Eric Wong
2021-02-10 7:07 ` [PATCH 1/6] lei *external: glob improvements, ls-external filtering Eric Wong
2021-02-10 7:07 ` Eric Wong [this message]
2021-02-10 7:07 ` [PATCH 3/6] test_common: support lei-daemon only testing Eric Wong
2021-02-10 7:07 ` [PATCH 4/6] lei ls-external: support --local and --remote Eric Wong
2021-02-10 7:07 ` [PATCH 5/6] lei: note some TODO items (curl, externals) Eric Wong
2021-02-10 7:07 ` [PATCH 6/6] net_reader: new package split from -watch Eric Wong
2021-02-10 8:38 ` [PATCH 7/6] lei_external: fix+test handling of escaped braces Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210070749.30391-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).