From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 9476C1F4B4 for ; Thu, 4 Feb 2021 02:06:55 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] pkt_op: do not exit subroutine via "next" Date: Thu, 4 Feb 2021 02:06:54 +0000 Message-Id: <20210204020654.17021-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: "next" apparently doesn't work in "do {} while" loops, so just use "while" as it makes no difference, here. --- lib/PublicInbox/PktOp.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/PktOp.pm b/lib/PublicInbox/PktOp.pm index 10d76da0..5d8e78ea 100644 --- a/lib/PublicInbox/PktOp.pm +++ b/lib/PublicInbox/PktOp.pm @@ -48,7 +48,7 @@ sub event_step { my ($self) = @_; my $c = $self->{sock}; my $msg; - do { + while (1) { my $n = recv($c, $msg, 4096, 0); unless (defined $n) { return if $! == EAGAIN; @@ -70,7 +70,7 @@ sub event_step { my ($sub, @args) = @$op; $sub->(@args, @pargs); return $self->close if $msg eq ''; # close on EOF - } while (1); + } } 1;