From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 7B7A81FB06 for ; Sun, 24 Jan 2021 11:46:56 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 9/9] smsg: parse_references: micro-optimization Date: Sun, 24 Jan 2021 04:46:55 -0700 Message-Id: <20210124114655.12815-10-e@80x24.org> In-Reply-To: <20210124114655.12815-1-e@80x24.org> References: <20210124114655.12815-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: With Perl 5.10+, we can rely on the defined-or-assignment (//=) operator to avoid repeatedly rewriting an SV. This may not provide a measurable difference here, but it's more consistent with current style where things like commit a05445fb400108e60ede7d377cf3b26a0392eb24 ("config: config_fh_parse: micro-optimize") provide a measurable improvement. --- lib/PublicInbox/Smsg.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/Smsg.pm b/lib/PublicInbox/Smsg.pm index 2b72e8b5..b4cc2ecb 100644 --- a/lib/PublicInbox/Smsg.pm +++ b/lib/PublicInbox/Smsg.pm @@ -83,7 +83,7 @@ sub parse_references ($$$) { warn "References: <$ref> too long, ignoring\n"; next; } - push(@keep, $ref) unless $seen{$ref}++; + $seen{$ref} //= push(@keep, $ref); } $smsg->{references} = '<'.join('> <', @keep).'>' if @keep; \@keep;