unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/3] testcommon: prepare_redirects: fix error message
Date: Sun,  3 Jan 2021 09:48:41 +0000	[thread overview]
Message-ID: <20210103094842.22906-3-e@80x24.org> (raw)
In-Reply-To: <20210103094842.22906-1-e@80x24.org>

I never hit these die() calls, but noticed it while debugging
another problem on FreeBSD.
---
 lib/PublicInbox/TestCommon.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index 56f04bd4..16ae2650 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -141,9 +141,9 @@ sub _prepare_redirects ($) {
 	for (my $fd = 0; $fd <= $#io_mode; $fd++) {
 		my $fh = $fhref->[$fd] or next;
 		my ($oldfh, $mode) = @{$io_mode[$fd]};
-		open my $orig, $mode, $oldfh or die "$$oldfh $mode stash: $!";
+		open my $orig, $mode, $oldfh or die "$oldfh $mode stash: $!";
 		$orig_io->[$fd] = $orig;
-		open $oldfh, $mode, $fh or die "$$oldfh $mode redirect: $!";
+		open $oldfh, $mode, $fh or die "$oldfh $mode redirect: $!";
 	}
 	$orig_io;
 }

  parent reply	other threads:[~2021-01-03  9:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-03  9:48 [PATCH 0/3] lei-related test fixes Eric Wong
2021-01-03  9:48 ` [PATCH 1/3] t/lei: use $lei->() callback wrapper Eric Wong
2021-01-03  9:48 ` Eric Wong [this message]
2021-01-03  9:48 ` [PATCH 3/3] spawn: support send_fd+recv_fd w/o IO::FDPass Eric Wong
2021-01-03 11:24 ` [PATCH 0/2] fix race from stdout buffering in FD pass exit Eric Wong
2021-01-03 11:24   ` [PATCH 1/2] send and receive all 3 FDs at once Eric Wong
2021-01-03 11:24   ` [PATCH 2/2] lei: fix output race in client/daemon mode Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210103094842.22906-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).