From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 0/6] process pipe improvements
Date: Fri, 1 Jan 2021 19:13:38 -1400 [thread overview]
Message-ID: <20210102091344.13477-1-e@80x24.org> (raw)
The DS::in_loop clobbering in MboxReader annoyed me and drove
this series.
I wanted to do it for the bidirectional pipes with
"git cat-file --batch", too, but there seems to be some
lifetime management issues which get hard-to-control
with things like the the waitpid(..,WNOHANG) call
in GitAsyncCat. Maybe switching --batch + DS to use UNIX
sockets can be done to save FDs (or I'm too brain-damaged
to figure this out).
But right now, all of our codebase is robust against children
attempting to reap siblings (or PIDs of former siblings)
Eric Wong (6):
processpipe: allow synchronous close to set $?
processpipe: lazy-require PublicInbox::DS for dwaitpid
git: qx: waitpid synchronously via ProcessPipe->CLOSE
import: switch to using ProcessPipe
git: manifest_entry: use ProcessPipe via popen_rd
qspawn: switch to ProcessPipe via popen_rd
lib/PublicInbox/Git.pm | 20 +++++++++-----
lib/PublicInbox/Import.pm | 23 +++++++---------
lib/PublicInbox/MboxReader.pm | 3 ---
lib/PublicInbox/ProcessPipe.pm | 49 +++++++++++++++++++++-------------
lib/PublicInbox/Qspawn.pm | 15 +++++------
lib/PublicInbox/Spawn.pm | 10 +++----
t/mbox_reader.t | 17 ++++++++++++
t/spawn.t | 38 ++++++++++++++++++++++++++
8 files changed, 119 insertions(+), 56 deletions(-)
next reply other threads:[~2021-01-02 9:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-02 9:13 Eric Wong [this message]
2021-01-02 9:13 ` [PATCH 1/6] processpipe: allow synchronous close to set $? Eric Wong
2021-01-02 9:13 ` [PATCH 2/6] processpipe: lazy-require PublicInbox::DS for dwaitpid Eric Wong
2021-01-02 9:13 ` [PATCH 3/6] git: qx: waitpid synchronously via ProcessPipe->CLOSE Eric Wong
2021-01-02 9:13 ` [PATCH 4/6] import: switch to using ProcessPipe Eric Wong
2021-01-02 9:13 ` [PATCH 5/6] git: manifest_entry: use ProcessPipe via popen_rd Eric Wong
2021-01-02 9:13 ` [PATCH 6/6] qspawn: switch to " Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210102091344.13477-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).