[PATCH] t/config: test --get-urlmatch for git <2.26

[Eric Wong <e@80x24.org>]

Ali Alnubani <alialnu@nvidia.com> wrote:
> t/config.t ................... 1/?
> #   Failed test 'urlmatch hit'
> #   at t/config.t line 249.
> #          got: undef
> #     expected: '9'
> # Looks like you failed 1 test of 95.

Just fixing the test, for now; I guess -watch documentation
could use some updates or the code updated to not depend on
git for URL matching at all (it's not in libgit2, either,
but wildcard => Perl regexp translation isn't too bad, and
we'll be needing it elsewhere, I think)

----------8<---------
Subject: [PATCH] t/config: test --get-urlmatch for git <2.26

While git 1.8.5 learned --get-urlmatch, git did not learn to
match URLs against wildcards until 2.26.  So only depend on
1.8.5 for this test since 2.26 is too new.

Reported-by: Ali Alnubani <alialnu@nvidia.com>
Link: https://public-inbox.org/meta/DM6PR12MB49106F8E3BD697B63B943A22DADB0@DM6PR12MB4910.namprd12.prod.outlook.com/
---
 t/config.t | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/t/config.t b/t/config.t
index 99a7fef4..7fb44acc 100644
--- a/t/config.t
+++ b/t/config.t
@@ -234,12 +234,13 @@ EOF
 }
 
 SKIP: {
+	# XXX wildcard match requires git 2.26+
 	require_git('1.8.5', 2) or
 		skip 'git 1.8.5+ required for --url-match', 2;
 	my $f = "$tmpdir/urlmatch";
 	open my $fh, '>', $f or BAIL_OUT $!;
 	print $fh <<EOF or BAIL_OUT $!;
-[imap "imap://*.example.com"]
+[imap "imap://mail.example.com"]
 	pollInterval = 9
 EOF
 	close $fh or BAIL_OUT;