From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id E7FED1FB06 for ; Sun, 20 Dec 2020 06:30:16 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 5/6] daemon: kill_workers: eliminate unnecessary loop Date: Sun, 20 Dec 2020 06:30:15 +0000 Message-Id: <20201220063016.20959-6-e@80x24.org> In-Reply-To: <20201220063016.20959-1-e@80x24.org> References: <20201220063016.20959-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: The `kill' perl op takes multiple PIDs, so there's no need to iterate through the %pids hash. --- lib/PublicInbox/Daemon.pm | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/PublicInbox/Daemon.pm b/lib/PublicInbox/Daemon.pm index eeac3bd2..1762be0b 100644 --- a/lib/PublicInbox/Daemon.pm +++ b/lib/PublicInbox/Daemon.pm @@ -419,11 +419,8 @@ sub upgrade { # $_[0] = signal name or number (unused) } sub kill_workers ($) { - my ($s) = @_; - - while (my ($pid, $id) = each %pids) { - kill $s, $pid; - } + my ($sig) = @_; + kill $sig, keys(%pids); } sub upgrade_aborted ($) {