From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] nntpd: skip inboxes w/o {newsgroup}
Date: Fri, 18 Dec 2020 11:54:37 +0000 [thread overview]
Message-ID: <20201218115437.23714-1-e@80x24.org> (raw)
So we don't trigger an uninitialized variable warning :x
---
lib/PublicInbox/NNTPD.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/NNTPD.pm b/lib/PublicInbox/NNTPD.pm
index 953228d0..7f9a1d58 100644
--- a/lib/PublicInbox/NNTPD.pm
+++ b/lib/PublicInbox/NNTPD.pm
@@ -38,8 +38,8 @@ sub refresh_groups {
my $groups = $pi_cfg->{-by_newsgroup}; # filled during each_inbox
$pi_cfg->each_inbox(sub {
my ($ibx) = @_;
- my $ngname = $ibx->{newsgroup};
- if (defined($ngname) && $ibx->nntp_usable) {
+ my $ngname = $ibx->{newsgroup} // return;
+ if ($ibx->nntp_usable) {
# only valid if msgmap and over works
# preload to avoid fragmentation:
$ibx->description;
reply other threads:[~2020-12-18 11:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201218115437.23714-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).