unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] import: drop X-Status in addition to Status
@ 2020-12-17  9:14 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-12-17  9:14 UTC (permalink / raw)
  To: meta

It's actually supported by mutt, dovecot[1], and likely some other
software to augment the Status: header.  While dovecot doesn't
expose X-Status to clients, mutt will write 'A' (answered) and
'F' to X-Status (but not T (draft)).

So we'll drop it like we do Status since it's not suitable for
public mail, but stick it in an @UNWANTED_HEADERS array will
allow us to configure an override if needed.

[1]  https://doc.dovecot.org/configuration_manual/mail_location/mbox/
---
 lib/PublicInbox/Import.pm | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index 1a226cc7..2cb4896a 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -328,11 +328,13 @@ sub extract_cmt_info ($;$) {
 }
 
 # kill potentially confusing/misleading headers
+our @UNWANTED_HEADERS = (qw(Bytes Lines Content-Length),
+			qw(Status X-Status));
 sub drop_unwanted_headers ($) {
-	my ($mime) = @_;
-
-	$mime->header_set($_) for qw(Bytes Lines Content-Length Status);
-	$mime->header_set($_) for @PublicInbox::MDA::BAD_HEADERS;
+	my ($eml) = @_;
+	for (@UNWANTED_HEADERS, @PublicInbox::MDA::BAD_HEADERS) {
+		$eml->header_set($_);
+	}
 }
 
 # used by V2Writable, too

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-12-17  9:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-17  9:14 [PATCH] import: drop X-Status in addition to Status Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).