From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7B59C1F4B4 for ; Thu, 10 Dec 2020 21:43:33 +0000 (UTC) Received: by mail-qt1-x831.google.com with SMTP id h19so4939498qtq.13 for ; Thu, 10 Dec 2020 13:43:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=eU+2zWoAr05yw2eZ3JHCrSF3fdLcy+bIW2gKD7dc3Mw=; b=aMJ9sWd/zVExtM0b07i3+4j2K7iD7fcCcpCQaxHnJkDwL6qDE3RNfBfl708jdvmh2l Qm8+OGKFNikSws2ray4vTQt2hc3NBX/Br51PMoirmqNO7fhtoA4emuZ6v1SKNskb7KFY Z4+wVsH2h2ROY3qK1anzyQTaRSZzTP+gws5Eo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=eU+2zWoAr05yw2eZ3JHCrSF3fdLcy+bIW2gKD7dc3Mw=; b=SoNjnHZ6GkabEtONiAJjfty2RQfhx8CoKJoBd34wSM0oVbUHlv83m1ybAmT8Ov6wgY oHoLID2ICxRzdgrGKpWlhy5761UWU+1kvt0tH8udG5JNUk3zJX4O3Ris5cTnr1iBVxNS z+Of2Q2zI0NSnaVL6lOz7pDvwzE+lpc9dFKtDQIGsG407f4/fhFdTXnLbGyFC347ii34 cYdYiPEsePQnRHHrTQBPb0OYRVQX7Eh5GukzO5UhGMkYmDOREkXD3uYknINybOCUXm93 aQeNdtRfWRCfhnB7ILOJk7CyYAb1kwed184Fb6soE3zz7d23hepLCQupgmJ3kcuQ+PSr 7hIA== X-Gm-Message-State: AOAM532LUNR3Jpc2oNdI+FZpDA7nxAV5xtCNVCWYylFNkY594VUShld5 sHTT6szSeproCYHpl2XuPWzftg== X-Google-Smtp-Source: ABdhPJydZvwLDl5CWrFUHW6BCyMzipdNID0WJYRxBT14HxTYzNga3z8uhpeAAJjAoBtXb6QN60NMHw== X-Received: by 2002:ac8:6651:: with SMTP id j17mr11693853qtp.176.1607636612134; Thu, 10 Dec 2020 13:43:32 -0800 (PST) Received: from chatter.i7.local ([89.36.78.230]) by smtp.gmail.com with ESMTPSA id u20sm4823225qtb.9.2020.12.10.13.43.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Dec 2020 13:43:31 -0800 (PST) Date: Thu, 10 Dec 2020 16:43:29 -0500 From: Konstantin Ryabitsev To: Eric Wong Cc: meta@public-inbox.org Subject: Re: Extra newline when retrieving messages Message-ID: <20201210214329.do66z6gzvepxc5w3@chatter.i7.local> Mail-Followup-To: Eric Wong , meta@public-inbox.org References: <20201210202145.7agtcmrtl5jec42d@chatter.i7.local> <20201210205540.GA10371@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201210205540.GA10371@dcvr> List-Id: On Thu, Dec 10, 2020 at 08:55:40PM +0000, Eric Wong wrote: > Konstantin Ryabitsev wrote: > > Hello: > > > > While investigating why some of the messages retrieved via > > lore.kernel.org were failing DKIM checks, I realized that > > public-inbox-httpd appends an extra newline to message bodies. This > > newline isn't present in git backends, just in messages retrieved via > > (at least) public-inbox-httpd. > > It looks like a regression from commit dbdc7a42dd885523 (2016-04-11); > which now doesn't make sense, though very little is making sense > to me nowadays :< Actually, my conclusions were wrong and the problem is not with the newline -- it's the extra inserted headers. So you're not the only person confused here. :) The message that tripped me up is this one: https://lore.kernel.org/alsa-devel/20201210152541.191728-1-amadeuszx.slawinski@linux.intel.com/raw The DKIM signature in that message is: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1607605851; bh=RloCOZ1mS9qShbBGvPnUerOnMg14SHidcYi1OxvdtE0=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=nBOdKYbMY44uVJMlw++UIMx03JWn334I/F5uyH5hmhU9h9/cFQTfZL0WAwPzzG7nL pT9M4ElwsSqu8isrhJd7QV8q8DNvu+cRmGKbGOVLIEMhlYU87iHvIATKQmchLQv3xR OixHf1955oAoTFU/n5eqjaZdLhyfUtSo5oCdxg7Y= The problem here is that List-Archive is included in the list of signed headers, but when we retrieve the message via lore.kernel.org, it inserts an additional couple of headers: Archived-At: List-Archive: This is what causes DKIM verification to fail, and NOT the newline: $ curl -s \ https://lore.kernel.org/alsa-devel/20201210152541.191728-1-amadeuszx.slawinski@linux.intel.com/raw \ | dkimverify signature verification failed $ curl -s \ https://lore.kernel.org/alsa-devel/20201210152541.191728-1-amadeuszx.slawinski@linux.intel.com/raw \ | grep -v '